Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report error locus within instrumented code #170

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Report error locus within instrumented code #170

merged 6 commits into from
Jan 10, 2024

Conversation

gagbo
Copy link
Member

@gagbo gagbo commented Jan 4, 2024 •
edited
Loading

This fixes a small regression introduced when fixing instrumentation of async_trait code.

  • Add failing locus test
  • Let rust parse impl automatically

Checklist

  • Changelog updated

@gagbo
Add failing locus test
42dcdb6
@gagbo
Let rust parse impl automatically
1b8382d 
Letting Rust parse the impl block allows us to keep the same TokenStream as input in the autometrics macro code, even when async_trait is involved.

Keeping the original TokenStream keeps the Span information in method/function bodies so error reporting in instrumented code is not absorbed in "#[autometrics]" span.

This also simplifies the parsing code a little bit.
@gagbo
Update CHANGELOG
63a5e15
@gagbo
Copy link
Member Author

gagbo commented Jan 4, 2024 •
edited
Loading

So apparently it makes exemplars disappear :( (it was a precedence issue)

mellowagain
mellowagain approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@mellowagain mellowagain left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! we should release a new release after this is merged and the other issue with the otel exporter http client is fixed

autometrics/tests/error_locus.rs Outdated Show resolved Hide resolved
autometrics/tests/exemplars_test.rs Outdated Show resolved Hide resolved
@gagbo
Review
6e27987 
Gather all trybuild tests

Remove extra println used in failing tests
@gagbo gagbo merged commit bbba7c1 into main Jan 10, 2024
1 check passed
@gagbo gagbo deleted the report_error_locus branch January 10, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mellowagain mellowagain mellowagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gagbo @mellowagain