Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update to @opentelemetry/api v1.0.0-rc.0 #30

Merged
merged 2 commits into from
Apr 26, 2021

Conversation

turneand
Copy link
Contributor

Required upgrade in order to remain compatible with the latest opentelemetry releases.

Update to 1.0.0-rc.0 of the API and 0.19 of the other libraries.

Also switched the API dependency to be a peerDependency to remain consistent with the changes done in the opentelemtry APIs under open-telemetry/opentelemetry-js#2074


| OpenTelemetry API Version | Minimum Fastify OpenTelemetry Version |
| ------------------------------- | ------------------------------------------ |
| `@opentelemetry/api@1.0.0-rc.0` | `@autotelic/fastify-opentelemetry@0.12.0` |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, may need to change the version under @fastify-opentelemetry version here, depending on what you want it released as

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for sprucing it up! 😎

@turneand turneand force-pushed the opentelemetry-update branch from 16a3227 to 9bf67ad Compare April 26, 2021 11:24
Copy link
Collaborator

@HW13 HW13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initiative on this! Just a couple tweaks in package.json and we're good to go 👍

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved

| OpenTelemetry API Version | Minimum Fastify OpenTelemetry Version |
| ------------------------------- | ------------------------------------------ |
| `@opentelemetry/api@1.0.0-rc.0` | `@autotelic/fastify-opentelemetry@0.12.0` |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for sprucing it up! 😎

@turneand turneand requested a review from HW13 April 26, 2021 17:23
Copy link
Collaborator

@HW13 HW13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎 👍

@HW13 HW13 merged commit eab28b2 into autotelic:main Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants