-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update to @opentelemetry/api v1.0.0-rc.0 #30
Conversation
|
||
| OpenTelemetry API Version | Minimum Fastify OpenTelemetry Version | | ||
| ------------------------------- | ------------------------------------------ | | ||
| `@opentelemetry/api@1.0.0-rc.0` | `@autotelic/fastify-opentelemetry@0.12.0` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, may need to change the version under @fastify-opentelemetry version here, depending on what you want it released as
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for sprucing it up! 😎
16a3227
to
9bf67ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the initiative on this! Just a couple tweaks in package.json
and we're good to go 👍
|
||
| OpenTelemetry API Version | Minimum Fastify OpenTelemetry Version | | ||
| ------------------------------- | ------------------------------------------ | | ||
| `@opentelemetry/api@1.0.0-rc.0` | `@autotelic/fastify-opentelemetry@0.12.0` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for sprucing it up! 😎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😎 👍
Required upgrade in order to remain compatible with the latest opentelemetry releases.
Update to 1.0.0-rc.0 of the API and 0.19 of the other libraries.
Also switched the API dependency to be a peerDependency to remain consistent with the changes done in the opentelemtry APIs under open-telemetry/opentelemetry-js#2074