Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clippy an optional dep #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Manishearth
Copy link

This way people can use this crate on stable. Compile with cargo build --features dev to use clippy

@GitCop
Copy link

GitCop commented Dec 24, 2015

There were the following issues with your Pull Request

  • Commit: 51f6727
    • Commits must be in the following format: %{type}/%{scope}: %{description}

Guidelines are available at https://github.com/autumnai/leaf/blob/develop/CONTRIBUTING.md#git-commit-guidelines


This message was auto-generated by https://gitcop.com

@GitCop
Copy link

GitCop commented Dec 24, 2015

There were the following issues with your Pull Request

  • Commit: bec80d5
    • Commits must be in the following format: %{type}/%{scope}: %{description}

Guidelines are available at https://github.com/autumnai/leaf/blob/develop/CONTRIBUTING.md#git-commit-guidelines


This message was auto-generated by https://gitcop.com

@Manishearth
Copy link
Author

Needs autumnai/phloem#15

@MichaelHirn
Copy link
Member

As @Manishearth stated, we should make cuticulla complay with the usual clippy handling we have at the other crates. But phloem needs to be replaced first with collenchyma.

I cc @hobofan, maybe he has a local branch for this.

Progress is tracked at #19 which blocks the merge of this PR.

@hobofan hobofan self-assigned this Jan 14, 2016
@homu
Copy link
Collaborator

homu commented Apr 17, 2016

☔ The latest upstream changes (presumably #21) made this pull request unmergeable. Please resolve the merge conflicts.

@hobofan hobofan removed their assignment Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants