Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(tests): require //go:build test tag if importing test packages outside of _test.go files #3173

Merged
merged 18 commits into from
Jul 8, 2024
Merged

build(tests): require //go:build test tag if importing test packages outside of _test.go files #3173

merged 18 commits into from
Jul 8, 2024

Commits on Jul 4, 2024

  1. build(tests): require //go:build test tag if importing "testing" ou… 

    …tside of `_test.go` files
    @ARR4N
    ARR4N committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    f8b785c View commit details
    Browse the repository at this point in the history

  2. fix: add test tag to fuzzing

    @ARR4N
    ARR4N committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    0f630cc View commit details
    Browse the repository at this point in the history

  3. fix: temporary workaround for bootstrap test

    @ARR4N
    ARR4N committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    007dd75 View commit details
    Browse the repository at this point in the history

  4. fix: exclude files needed for compiling AvalancheGo binary

    @ARR4N
    ARR4N committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    02b44c0 View commit details
    Browse the repository at this point in the history

  5. fix: it builds! (Yes, I'm using CI as a build farm)

    @ARR4N
    ARR4N committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    cdd54cb View commit details
    Browse the repository at this point in the history

  6. chore: run golangci-lint with test tag + include new test in defa… 

    …ult linters
    @ARR4N
    ARR4N committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    7aec2b1 View commit details
    Browse the repository at this point in the history

  7. fix(lint): explicit find root

    @ARR4N
    ARR4N committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    24b3cac View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. chore: add test build tag to files importing testify/*

    @ARR4N
    ARR4N committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    09be7d2 View commit details
    Browse the repository at this point in the history

  2. feat(linter): detect files importing testify/*

    @ARR4N
    ARR4N committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    e410926 View commit details
    Browse the repository at this point in the history

  3. fix: placate ginkgo

    @ARR4N
    ARR4N committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    cdaf587 View commit details
    Browse the repository at this point in the history

  4. fix: shell linting

    @ARR4N
    ARR4N committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    d9af4ad View commit details
    Browse the repository at this point in the history

  5. fix: more ginkgo --tags test

    @ARR4N
    ARR4N committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    42251a6 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into arr4n/test-only-build-tags

    @ARR4N
    ARR4N committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    b030d5d View commit details
    Browse the repository at this point in the history

  7. refactor: remove test || !test workaround

    @ARR4N
    ARR4N committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    3a91b1d View commit details
    Browse the repository at this point in the history

  8. refactor: remove final test || !test workaround

    @ARR4N
    ARR4N committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    b7f0222 View commit details
    Browse the repository at this point in the history

  9. Revert "refactor: remove final test || !test workaround" 

    This reverts commit b7f0222 because it breaks a number of CI tests. There remains an open issue to do this (in a different PR).
    @ARR4N
    ARR4N committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    6abc968 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. chore: VSCode gopls and testing tags

    @ARR4N
    ARR4N committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    f70bfb0 View commit details
    Browse the repository at this point in the history

  2. chore: revert removal of .vscode* from .gitignore

    @ARR4N
    ARR4N committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    c531c88 View commit details
    Browse the repository at this point in the history