Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast to arrays to avoid nils #5676

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Cast to arrays to avoid nils #5676

merged 1 commit into from
Sep 4, 2024

Conversation

cjcolvar
Copy link
Member

This fixes the case when the solr document doesn't have the edit_access_person_ssim field and similar cases. Without this fix an error would occur when calling editors because nil - managers raises a NoMethodError.

@cjcolvar cjcolvar marked this pull request as ready for review September 4, 2024 19:58
masaball
masaball approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@masaball masaball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cjcolvar cjcolvar merged commit 9473f86 into develop Sep 4, 2024
2 checks passed
@cjcolvar cjcolvar deleted the no_managers branch September 4, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masaball masaball masaball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjcolvar @masaball