Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes propsed in this PR:
gather_peaks
method intoget_normalized_peaks
so overall absolute value max can be computed while gathering peaks instead of needing a separate pass through the peaks after.flatten
since it is expensive when run so frequentlyNote that the waveform fixture has slightly different values. I found that running the waveform job on a real item on mco-staging yielded different length and values even when run with the same code. But the small differences did not affect how it rendered in the SME so shouldn't be problem.
Resolves #5155