Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change audio player progress-bar and controls in embeds #6102

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Change audio player progress-bar and controls in embeds #6102

merged 2 commits into from
Nov 5, 2024

Conversation

Dananji
Copy link
Contributor

@Dananji Dananji commented Nov 5, 2024

Related issue: samvera-labs/ramp#705

Screenshot 2024-11-05 at 3 35 47 PM

cjcolvar
cjcolvar reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, but the screenshot appears to have a small regression with the volume thumb rendering slightly higher than middle of the bar.

@Dananji
Copy link
Contributor Author

Dananji commented Nov 5, 2024

After the last change:

Screenshot 2024-11-05 at 3 51 31 PM

cjcolvar
cjcolvar approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new progress bar thumb. I think it looks better as all white instead of grey.

@Dananji Dananji merged commit 45391e4 into develop Nov 5, 2024
2 checks passed
@Dananji Dananji deleted the audio-embed branch November 5, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @cjcolvar