Use structure_title for populating structure list #6105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masaball
force-pushed
the
display_section_title
branch
from
c7bbc6e
to
952ec1b
Compare
We have completely reworked how media object, master file, and playlist item titles are generated/displayed so limiting the creation of a display title from filename to only when there are multiple sections is no longer necessary.
This reverts commit d4216a1.
masaball
force-pushed
the
display_section_title
branch
from
952ec1b
to
677cae9
Compare
masaball
changed the title
cjcolvar
reviewed
Nov 9, 2024
cjcolvar
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have completely reworked how media object, master file, and playlist item titles are generated/displayed so limiting the creation of a display title from filename to only when there are multiple sections is no longer necessary.Actually, we created a method called
structure_titlespecifically for populating the structure list but apparently never switched to it. Reverted the changes todisplay_titleand tests, switched the canvas presenter to usestructure_titleinstead.Related issue: #6001