Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELF files LIEF vs. RetDec #457

Closed
libka-b opened this issue Jan 7, 2019 · 1 comment
Closed

ELF files LIEF vs. RetDec #457

libka-b opened this issue Jan 7, 2019 · 1 comment
Assignees
@PeterMatula
Labels
C-fileformat C-fileinfo enhancement T-format-elf

Comments

@libka-b
Copy link

libka-b commented Jan 7, 2019

fileinfo provides lesser info on imported libraries in ~1/20 cases than lief library.
@PeterMatula PeterMatula self-assigned this Jan 7, 2019
PeterMatula added a commit to avast/retdec-regression-tests that referenced this issue Jan 10, 2019
@PeterMatula
tools/fileinfo: test for avast/retdec#457
2c8616d
@PeterMatula PeterMatula mentioned this issue Jan 18, 2019
Merged
@PeterMatula
Copy link
Collaborator

Solved by #468.

Note: We received a list of test sample hashes (cca 23000) and scripts to compare the outputs of LIEF and RetDec (needed dynamic libs and imported functions). Oftentimes LIEF provided more info. After changes in the referenced PR, RetDec is not missing any information compared to LIEF in the tested samples - it is at least as good as LIEF.

PeterMatula added a commit that referenced this issue Jan 22, 2019
@PeterMatula
CHANGELOG.md: add entry for #457 fix.
fcefbea
PeterMatula added a commit to avast/retdec-regression-tests that referenced this issue Feb 21, 2019
@PeterMatula
tools/fileinfo: test for avast/retdec#457
aa8f3c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeterMatula PeterMatula

Labels
C-fileformat C-fileinfo enhancement T-format-elf
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PeterMatula @libka-b