TLS parsing and presentation #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metthal
requested changes
Mar 28, 2019
| @@ -68,6 +68,12 @@ class PeFormatParser64 : public PeFormatParser | |||
| virtual bool getDebugEntryPointerToRawData(unsigned long long index, unsigned long long& pointerToRawData) const override; | |||
| virtual unsigned long long getResourceDirectoryOffset() const override; | |||
| virtual const PeLib::ResourceNode* getResourceTreeRoot() const override; | |||
| virtual unsigned long long getTlsStartAddressOfRawData() const; | |||
There was a problem hiding this comment.
override is missing here and also on other lines under this one.
|
I went through the code once more and I am not sure whether this will correctly work for all 64-bit PE binaries. PeLib seems to be truncating half of bytes when returning attributes which are 64-bit. I think this may require modification of PeLib, more specifically |
|
Thanks for taking care of PE32+ but it will still need modification of pelib because it truncates them to 32-bit values ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread-local storage information and callback extraction
#417