Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: field analysis #43

Closed
wants to merge 2 commits into from
Closed

wip: field analysis #43

wants to merge 2 commits into from

Conversation

aviatesk
Copy link
Owner

@aviatesk aviatesk commented Aug 16, 2021 •
edited
Loading

  • fix infinite loop
  • desing how this analysis should improve existing SROA optimization pass
  • design FieldEscape
  • improve getfield handling, fix existing broken "field analysis" testset
  • add setfield! handling

@aviatesk aviatesk requested review from TH3CHARLie and vtjnash August 16, 2021 11:58
@aviatesk aviatesk changed the title RFC: field analysis wip: field analysis Aug 16, 2021
vtjnash
vtjnash reviewed Aug 16, 2021
View reviewed changes
src/EscapeAnalysis.jl Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Aug 16, 2021
View reviewed changes
src/EscapeAnalysis.jl Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Aug 16, 2021
View reviewed changes
src/EscapeAnalysis.jl Outdated Show resolved Hide resolved
Base automatically changed from avi/test to master August 17, 2021 05:41
aviatesk added a commit that referenced this pull request Aug 17, 2021
@aviatesk
fix strict lattice order ⋤
8f07831 
Pointed out at: 
#43 (comment)
@aviatesk aviatesk mentioned this pull request Aug 17, 2021
Merged
vtjnash pushed a commit that referenced this pull request Aug 17, 2021
@aviatesk
fix strict lattice order ⋤ (#44)
194a5b6 
Pointed out at: 
#43 (comment)
@aviatesk aviatesk mentioned this pull request Aug 27, 2021
Merged
@aviatesk aviatesk marked this pull request as draft September 22, 2021 07:01
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2021 •
edited
Loading

Codecov Report

Merging #43 (e7dcc5d) into master (f1820d4) will increase coverage by 3.48%.
The diff coverage is 89.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   70.75%   74.23%   +3.48%     
==========================================
  Files           1        1              
  Lines         359      427      +68     
==========================================
+ Hits          254      317      +63     
- Misses        105      110       +5
Impacted Files Coverage Δ
src/EscapeAnalysis.jl 74.23% <89.53%> (+3.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1820d4...e7dcc5d. Read the comment docs.

@aviatesk aviatesk force-pushed the avi/fieldanalysis branch 4 times, most recently from fe8eb05 to 69bfa21 Compare October 6, 2021 11:26
@aviatesk
Copy link
Owner Author

Close in favor of #54

@aviatesk aviatesk closed this Nov 15, 2021
@aviatesk aviatesk deleted the avi/fieldanalysis branch November 15, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aviatesk @codecov-commenter @vtjnash