From 508949b6b757daaa2e871e4710d1874b060f5593 Mon Sep 17 00:00:00 2001 From: sid-acryl <155424659+sid-acryl@users.noreply.github.com> Date: Fri, 19 Jul 2024 18:09:37 +0530 Subject: [PATCH] doc(ingest/looker): fix doc for sql parsing documentation (#10883) Co-authored-by: Harshal Sheth --- .../docs/sources/looker/lookml_post.md | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/metadata-ingestion/docs/sources/looker/lookml_post.md b/metadata-ingestion/docs/sources/looker/lookml_post.md index 773a917202f247..8a4bf823ffc27d 100644 --- a/metadata-ingestion/docs/sources/looker/lookml_post.md +++ b/metadata-ingestion/docs/sources/looker/lookml_post.md @@ -1,14 +1,11 @@ #### Configuration Notes -:::note - -The integration can use an SQL parser to try to parse the tables the views depends on. - -::: - -This parsing is disabled by default, but can be enabled by setting `parse_table_names_from_sql: True`. The default parser is based on the [`sqllineage`](https://pypi.org/project/sqllineage/) package. -As this package doesn't officially support all the SQL dialects that Looker supports, the result might not be correct. You can, however, implement a custom parser and take it into use by setting the `sql_parser` configuration value. A custom SQL parser must inherit from `datahub.utilities.sql_parser.SQLParser` -and must be made available to Datahub by ,for example, installing it. The configuration then needs to be set to `module_name.ClassName` of the parser. +1. If a view contains a liquid template (e.g. `sql_table_name: {{ user_attributes['db']}}.kafka_streaming.events }}`, with `db=ANALYTICS_PROD`), then you will need to specify the values of those variables in the `liquid_variable` config as shown below: + ```yml + liquid_variable: + user_attributes: + db: ANALYTICS_PROD + ``` ### Multi-Project LookML (Advanced)