Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New longitudinal fails for program encounter with no cancellation form #1056

Closed
4 tasks
nupoorkhandelwal opened this issue Oct 5, 2023 · 2 comments
Closed
4 tasks
Assignees
Labels
bug Something isn't working

Comments

@nupoorkhandelwal
Copy link
Contributor

nupoorkhandelwal commented Oct 5, 2023

Describe the bug
Currently, the new longitudinal export fails when a program encounter in the request is not mapped to a Cancel form.

To Reproduce
Steps to reproduce the behavior:

  1. Go to "Yenepoya" org >> Reports >> New Longitudinal Export
  2. Request json - With comments - https://github.com/avniproject/yenepoya/blob/master/New%20longitudinal%20request.json
  3. Remove comments and see the request fails and there is no downloadable error file
  4. Now remove the "Delivery" encounter under Pregnancy program >> The request will run and give results
  5. Basically, the Delivery encounter do not have Cancellation form.

Expected behavior
So, even if the cancel form is not mapped, the new longitudinal export should work fine

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Developer Checklist(Developer fixing the bug should fill this checklist)

  • Does the fix require extensive regression testing?
    • Yes
    • No
  • Are you mentioning the required scenarios that could be affected?
    • Yes
    • No
@nupoorkhandelwal nupoorkhandelwal moved this to New Issues in Avni Product Oct 5, 2023
@nupoorkhandelwal nupoorkhandelwal added the bug Something isn't working label Oct 5, 2023
@mahalakshme mahalakshme moved this from New Issues to Focus Items in Avni Product Oct 5, 2023
@mahalakshme mahalakshme moved this from Focus Items to In Analysis in Avni Product Oct 13, 2023
@mahalakshme
Copy link
Contributor

@nupoorkhandelwal you are right, its because the encounter type doesn't have cancellation form. would like to know why is that some encounter types need not have cancellation form.

@nupoorkhandelwal
Copy link
Contributor Author

@mahalakshme It is possible to remove the cancel form mapping under Forms, and since this is Delivery encounter, as part of requirement it must have been removed by implementor at some piont.

@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product Oct 16, 2023
@mahalakshme mahalakshme moved this from In Analysis Review to Ready in Avni Product Oct 17, 2023
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Oct 18, 2023
@petmongrels petmongrels self-assigned this Oct 18, 2023
petmongrels added a commit to avniproject/avni-server that referenced this issue Oct 18, 2023
@petmongrels petmongrels moved this from In Progress to Code Review Ready in Avni Product Oct 18, 2023
@himeshr himeshr moved this from Code Review Ready to In Code Review in Avni Product Oct 20, 2023
@himeshr himeshr moved this from In Code Review to QA Ready in Avni Product Oct 20, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Oct 27, 2023
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants