Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEA] File concept issue #1178

Closed
Tracked by #1614 ...
mahalakshme opened this issue Mar 21, 2024 · 5 comments
Closed
Tracked by #1614 ...

[DEA] File concept issue #1178

mahalakshme opened this issue Mar 21, 2024 · 5 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Mar 21, 2024

Issues:

env: staging, username: maha@apf_bnd_test, individual name: 'abc def'

AC:

  • The above should work for both create, edit and view flows as applicable
  • When multiple files are there display multiple links - View File - for each file for user to click and open in new tab
@mahalakshme mahalakshme converted this from a draft issue Mar 21, 2024
@mahalakshme mahalakshme changed the title [DEA] File and Video concept issue [DEA] File concept issue Mar 21, 2024
@mahalakshme mahalakshme added the good first issue Good for newcomers label Dec 5, 2024
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Dec 5, 2024
@vedfordev vedfordev self-assigned this Dec 5, 2024
@vedfordev vedfordev moved this from Ready to In Progress in Avni Product Dec 5, 2024
@vedfordev vedfordev moved this from In Progress to Code Review Ready in Avni Product Dec 6, 2024
@petmongrels petmongrels moved this from Code Review Ready to In Code Review in Avni Product Dec 9, 2024
@petmongrels
Copy link
Contributor

  • in fileOptions method, the check _.isNil(signedURL) should for empty array list
  • not sure whether mediaDataList can be null or it will empty array. pls test once.

@petmongrels petmongrels moved this from In Code Review to Code Review with Comments in Avni Product Dec 9, 2024
@vedfordev vedfordev moved this from Code Review with Comments to In Progress in Avni Product Dec 10, 2024
vedfordev added a commit that referenced this issue Dec 11, 2024
@vedfordev vedfordev moved this from In Progress to Code Review Ready in Avni Product Dec 11, 2024
@vedfordev
Copy link
Contributor

  • in fileOptions method, the check _.isNil(signedURL) should for empty array list
  • not sure whether mediaDataList can be null or it will empty array. pls test once.

changed _.isNill with _.isEmpty and other changes as well

@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product Dec 12, 2024
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Dec 12, 2024
@dinesh2096 dinesh2096 moved this from QA Ready to In QA in Avni Product Dec 12, 2024
@dinesh2096 dinesh2096 self-assigned this Dec 12, 2024
@dinesh2096
Copy link

  • When we upload the file greater the Kb we have mentioned we getting the error but it is saves as the error file and it is showing blank image.
  • In the file if we upload the image can we have the preview now the behavior is only downloading the image

QA Video :

Click here to watch the video

@dinesh2096 dinesh2096 moved this from In QA to QA Failed in Avni Product Dec 12, 2024
@vedfordev vedfordev moved this from QA Failed to In Progress in Avni Product Dec 13, 2024
vedfordev added a commit that referenced this issue Dec 13, 2024
@vedfordev vedfordev moved this from In Progress to In QA in Avni Product Dec 13, 2024
@dinesh2096
Copy link

QA Reference Video :

Click here to watch the video

@dinesh2096
Copy link

Know issue :

Click here to see the issue

@dinesh2096 dinesh2096 moved this from In QA to Done in Avni Product Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

5 participants