Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaccination Checklist not working properly #1288

Closed
Tracked by #1640
vedfordev opened this issue Jul 23, 2024 · 3 comments
Closed
Tracked by #1640

Vaccination Checklist not working properly #1288

vedfordev opened this issue Jul 23, 2024 · 3 comments
Assignees

Comments

@vedfordev
Copy link
Contributor

vedfordev commented Jul 23, 2024

Describe the bug
"dependentOn" flag not working properly.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to ck_uat vaccination checklist
  2. search Albendazole 3 and add "dependentOn": "bf5d2cdb-0713-4005-8135-d757e8b68707",
  3. Sync in the mobile app
  4. The dependentOn added above is not respected when displaying the Vaccination Checklist.

Root cause:

  • check in backend - dependentOn will be not be updated. select * from checklist_item_detail where uuid = 'ea4a2663-4a1f-4a59-b76e-c996a49a35af';
  • It shows in web-app but if you try to shit + command + r , again it remove dependentOn.

If we are updating via backend :

  1. add dependentOn via backend UPDATE public.checklist_item_detail SET dependent_on = 1166, last_modified_date_time = now() WHERE id = 1173;
  2. check the updated value.
  3. go to web-app form
  4. do some change ex change minDaysFromStartDate and save.
  5. again check it removes dependentOn.

Also check is_voided also working weirdly.

Analysis:

Try to follow the same steps above to reproduce the issue since the issue doesn't occur always.

Expected behaviour

  1. Vaccination checklist should work properly.
  2. Check everything thoroughly

Test Data
card

@github-project-automation github-project-automation bot moved this to New Issues in Avni Product Jul 23, 2024
@mahalakshme mahalakshme moved this from New Issues to Ready in Avni Product Jul 23, 2024
@1t5j0y 1t5j0y moved this from Ready to In Progress in Avni Product Jul 23, 2024
@1t5j0y 1t5j0y self-assigned this Jul 23, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented Jul 23, 2024

@vedfordev dependentOn for 'Albendazole 3' is getting saved correctly if 'Albendazole 2' is present in the json before 'Albendazole 3'. Just mentioning so you are not blocked and have a workaround. Continuing to look at this issue to see if further fix is required.

1t5j0y added a commit to avniproject/avni-server that referenced this issue Jul 24, 2024
@1t5j0y 1t5j0y moved this from In Progress to Code Review Ready in Avni Product Jul 24, 2024
@himeshr himeshr moved this from Code Review Ready to In Code Review in Avni Product Jul 24, 2024
himeshr added a commit to avniproject/avni-server that referenced this issue Jul 24, 2024
@himeshr himeshr moved this from In Code Review to QA Ready in Avni Product Jul 24, 2024
@vedfordev
Copy link
Contributor Author

@1t5j0y Done with the changes. currently it is working fine but it randomly set the order.

@1t5j0y
Copy link
Contributor

1t5j0y commented Jul 25, 2024

@vedfordev We've put in a fix as part of this card to make the order of items in the JSON irrelevant.

@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Jul 25, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to QA Ready in Avni Product Jul 25, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Jul 26, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Jul 29, 2024
@mahalakshme mahalakshme moved this from Done to Further Action Required in Avni Product Jul 30, 2024
@mahalakshme mahalakshme moved this from Further Action Required to Done in Avni Product Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants