Should be able to delete location type when no locations of that type exist

[mahalakshme]

As is:

Currently when a location type once created in App designer cant be deleted

Need:

For someone who is new, when they have set the hierarchy incorrectly when newly trying to setup, it becomes irreversible for them and leads to confusion

AC:

• DELETE icon needs to be enabled always.
• When no locations of that type exists, user should be able to delete that location type.
• When locations exist, show error message(toast message in the bottom) stating that 'Locations of this type exists. Delete them to proceed further.'

[dinesh2096]

• When we added the parent type for the location type and try to delete it we are getting a error

• And also if we deleted the location type by mistaken if the user want to readd the error is displayed

[1t5j0y]

Fixed 2nd issue by renaming address level type on deletion so same name can be used again for a new address level type.

Unable to simulate the 1st issue - was able to delete child type when it did not have any children or levels of that type. The error message in the screenshot is not the latest so perhaps there was incorrect version of server deployed while testing.

[dinesh2096]

• Still we are getting the same error did the deployment
  https://app.circleci.com/pipelines/github/avniproject/avni-server?branch=10.1.0

Click here to watch video

[mahalakshme]

@1t5j0y good to mention last_modified_by_id(using superadmin of yours) also I think, Previously when something via migrations have gone wrong it was with this, able to find a pattern and identified the root cause. Let me know if you think otherwise.

[1t5j0y]

good to have but not necessary for this particular one in my opinion since we are only touching already voided entities. Also, migrations should use last_modified_by_id 1 to differentiate migrations from manual fixes.

Maybe we need manual_update_history column for non transactional tables too.

[mahalakshme]

yeah agreed

[dinesh2096]

QA References :

Click here to watch the video