Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1333 | Interface for MetadataDiff #1334

Merged
merged 5 commits into from
Sep 27, 2024
Merged

Conversation

shraddha761
Copy link
Contributor

Issue -> #1333

Copy link
Contributor

@himeshr himeshr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make MetadataDiff methods renderJsonWithColor() and filterForms() easier to understand:

  • breaking into smaller methods
  • having self-explanatory method names for smaller methods
  • Create constants with explanatory names for conditions used in render method
    Ex: const areFilesMissing = (missingFilesNode) => {... some condition}

@1t5j0y
Copy link
Contributor

1t5j0y commented Sep 25, 2024

Refactoring looks good.

Few more comments:

  • Remove the typeof checks and use lodash (look for usages in the current code) methods like isNil, isEmpty to check for null, undefined, empty etc
  • Use constants for possible values of changeType

@1t5j0y 1t5j0y merged commit d80d83a into avniproject:master Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants