From 4a8af34609f27cba57d2469d630fee2501e5e627 Mon Sep 17 00:00:00 2001 From: Iain Beeston Date: Mon, 20 Jan 2025 12:53:29 +0000 Subject: [PATCH] Fixed argument prefix warnings If I run an app using avo with warnings enabled I get a LOT of warnings like this: avo-3.16.1/app/components/avo/fields/files_field/edit_component.html.erb:1: warning: `**' interpreted as argument prefix This is happening because a function is being called with `**` as the first argument but there are no brackets around the arguments. Adding brackets fixes the warning but it does not change the meaning, so I've done that for all field components. --- .../avo/fields/area_field/edit_component.html.erb | 2 +- .../avo/fields/area_field/show_component.html.erb | 2 +- .../avo/fields/badge_field/index_component.html.erb | 2 +- .../avo/fields/badge_field/show_component.html.erb | 2 +- .../avo/fields/belongs_to_field/edit_component.html.erb | 6 +++--- .../avo/fields/belongs_to_field/index_component.html.erb | 2 +- .../avo/fields/belongs_to_field/show_component.html.erb | 2 +- .../avo/fields/boolean_field/edit_component.html.erb | 2 +- .../avo/fields/boolean_field/index_component.html.erb | 2 +- .../avo/fields/boolean_field/show_component.html.erb | 2 +- .../avo/fields/boolean_group_field/edit_component.html.erb | 2 +- .../avo/fields/boolean_group_field/index_component.html.erb | 2 +- .../avo/fields/boolean_group_field/show_component.html.erb | 2 +- .../avo/fields/code_field/edit_component.html.erb | 2 +- .../avo/fields/code_field/show_component.html.erb | 2 +- .../avo/fields/country_field/edit_component.html.erb | 2 +- .../avo/fields/country_field/index_component.html.erb | 2 +- .../avo/fields/country_field/show_component.html.erb | 2 +- .../avo/fields/date_field/edit_component.html.erb | 2 +- .../avo/fields/date_field/index_component.html.erb | 2 +- .../avo/fields/date_field/show_component.html.erb | 2 +- .../avo/fields/date_time_field/edit_component.html.erb | 2 +- .../avo/fields/date_time_field/index_component.html.erb | 2 +- .../avo/fields/date_time_field/show_component.html.erb | 2 +- .../avo/fields/external_image_field/edit_component.html.erb | 2 +- .../fields/external_image_field/index_component.html.erb | 2 +- .../avo/fields/external_image_field/show_component.html.erb | 2 +- .../avo/fields/file_field/edit_component.html.erb | 2 +- .../avo/fields/file_field/index_component.html.erb | 2 +- .../avo/fields/file_field/show_component.html.erb | 2 +- .../avo/fields/files_field/edit_component.html.erb | 2 +- .../avo/fields/files_field/index_component.html.erb | 2 +- .../avo/fields/files_field/show_component.html.erb | 2 +- .../avo/fields/gravatar_field/index_component.html.erb | 2 +- .../avo/fields/gravatar_field/show_component.html.erb | 2 +- .../avo/fields/has_one_field/index_component.html.erb | 2 +- app/components/avo/fields/id_field/edit_component.html.erb | 2 +- app/components/avo/fields/id_field/index_component.html.erb | 2 +- app/components/avo/fields/id_field/show_component.html.erb | 2 +- .../avo/fields/key_value_field/edit_component.html.erb | 2 +- .../avo/fields/key_value_field/show_component.html.erb | 2 +- .../avo/fields/location_field/edit_component.html.erb | 2 +- .../avo/fields/location_field/show_component.html.erb | 2 +- .../avo/fields/markdown_field/edit_component.html.erb | 2 +- .../avo/fields/markdown_field/show_component.html.erb | 2 +- .../avo/fields/number_field/edit_component.html.erb | 2 +- .../avo/fields/number_field/index_component.html.erb | 2 +- .../avo/fields/number_field/show_component.html.erb | 2 +- .../avo/fields/password_field/edit_component.html.erb | 2 +- .../avo/fields/preview_field/index_component.html.erb | 2 +- .../avo/fields/progress_bar_field/edit_component.html.erb | 2 +- .../avo/fields/progress_bar_field/index_component.html.erb | 2 +- .../avo/fields/progress_bar_field/show_component.html.erb | 2 +- .../avo/fields/radio_field/edit_component.html.erb | 2 +- .../avo/fields/radio_field/index_component.html.erb | 2 +- .../avo/fields/radio_field/show_component.html.erb | 2 +- .../avo/fields/select_field/edit_component.html.erb | 2 +- .../avo/fields/select_field/index_component.html.erb | 2 +- .../avo/fields/select_field/show_component.html.erb | 2 +- .../avo/fields/status_field/edit_component.html.erb | 2 +- .../avo/fields/status_field/index_component.html.erb | 2 +- .../avo/fields/status_field/show_component.html.erb | 2 +- .../avo/fields/tags_field/edit_component.html.erb | 4 ++-- .../avo/fields/tags_field/index_component.html.erb | 2 +- .../avo/fields/tags_field/show_component.html.erb | 2 +- .../avo/fields/text_field/edit_component.html.erb | 2 +- .../avo/fields/text_field/index_component.html.erb | 2 +- .../avo/fields/text_field/show_component.html.erb | 2 +- .../avo/fields/textarea_field/edit_component.html.erb | 2 +- .../avo/fields/textarea_field/show_component.html.erb | 2 +- .../avo/fields/time_field/edit_component.html.erb | 2 +- .../avo/fields/time_field/index_component.html.erb | 2 +- .../avo/fields/time_field/show_component.html.erb | 2 +- .../avo/fields/tiptap_field/edit_component.html.erb | 2 +- .../avo/fields/tiptap_field/show_component.html.erb | 2 +- .../avo/fields/trix_field/edit_component.html.erb | 2 +- .../avo/fields/trix_field/show_component.html.erb | 2 +- 77 files changed, 80 insertions(+), 80 deletions(-) diff --git a/app/components/avo/fields/area_field/edit_component.html.erb b/app/components/avo/fields/area_field/edit_component.html.erb index 28ffcb87e8..5b410aa6d1 100644 --- a/app/components/avo/fields/area_field/edit_component.html.erb +++ b/app/components/avo/fields/area_field/edit_component.html.erb @@ -1,4 +1,4 @@ -<%= field_wrapper **field_wrapper_args do %> +<%= field_wrapper(**field_wrapper_args) do %> <%= @form.text_field field.id, value: field.value.to_s, class: classes("w-full"), diff --git a/app/components/avo/fields/area_field/show_component.html.erb b/app/components/avo/fields/area_field/show_component.html.erb index f4377507c7..0466bf9de5 100644 --- a/app/components/avo/fields/area_field/show_component.html.erb +++ b/app/components/avo/fields/area_field/show_component.html.erb @@ -1,4 +1,4 @@ -<%= field_wrapper **field_wrapper_args do %> +<%= field_wrapper(**field_wrapper_args) do %> <% if field.value.present? %> <%= area_map field.map_data, **field.mapkick_options %> <% else %> diff --git a/app/components/avo/fields/badge_field/index_component.html.erb b/app/components/avo/fields/badge_field/index_component.html.erb index 4fdf9e07b1..6d137ecb98 100644 --- a/app/components/avo/fields/badge_field/index_component.html.erb +++ b/app/components/avo/fields/badge_field/index_component.html.erb @@ -1,3 +1,3 @@ -<%= index_field_wrapper **field_wrapper_args, flush: true do %> +<%= index_field_wrapper(**field_wrapper_args, flush: true) do %> <%= render Avo::Fields::Common::BadgeViewerComponent.new value: @field.value, options: @field.options %> <% end %> diff --git a/app/components/avo/fields/badge_field/show_component.html.erb b/app/components/avo/fields/badge_field/show_component.html.erb index 461a7b8bbe..b18ed6fded 100644 --- a/app/components/avo/fields/badge_field/show_component.html.erb +++ b/app/components/avo/fields/badge_field/show_component.html.erb @@ -1,3 +1,3 @@ -<%= field_wrapper **field_wrapper_args do %> +<%= field_wrapper(**field_wrapper_args) do %> <%= render Avo::Fields::Common::BadgeViewerComponent.new value: @field.value, options: @field.options %> <% end %> diff --git a/app/components/avo/fields/belongs_to_field/edit_component.html.erb b/app/components/avo/fields/belongs_to_field/edit_component.html.erb index b38be635bd..5d7a30e362 100644 --- a/app/components/avo/fields/belongs_to_field/edit_component.html.erb +++ b/app/components/avo/fields/belongs_to_field/edit_component.html.erb @@ -5,7 +5,7 @@ data-association="<%= @field.id %>" data-association-class="<%= @field&.target_resource&.model_class || nil %>" > - <%= field_wrapper **field_wrapper_args, label_for: @field.polymorphic_form_field_label, help: @field.polymorphic_help || '' do %> + <%= field_wrapper(**field_wrapper_args, label_for: @field.polymorphic_form_field_label, help: @field.polymorphic_help || '') do %> <%= @form.select @field.type_input_foreign_key, @field.types.map { |type| [Avo.resource_manager.get_resource_by_model_class(type.to_s).name, type.to_s] }, { value: @field.value, @@ -32,7 +32,7 @@ <% @field.types.each do |type| %>