Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

[PLTF-1720] Publish Avvo gems to both Packagecloud and Artifactory #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vicente-ramos
Copy link

@nickmarden This PR is special because it start to implement Gemfile.lock resolution. Please check if next steps are according to expectations:

  1. As it is a library next dependencies were move from Gemfile to gemspec:
    mocha for general
    test-unit for test
  2. Gemfile.lock was already listed in .gitignore (if was not, it would be added)

Gemfile Show resolved Hide resolved
@@ -7,6 +7,14 @@ http://delsolr.rubyforge.org
DelSolr is a light weight ruby wrapper for solr. It's intention is to expose the full power of solr queries
while keeping the interface as ruby-esque as possible.

== Tested Ruby Versions
Version Result

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This formatting is not cosmetic. Please use the format you've used elsewhere.

Please note that you can use "View File" in your PR (or the "compare branches UI") on Github to see what your changes look like before you submit the PR for review.

Screen Shot 2020-10-20 at 9 13 36 AM

Screen Shot 2020-10-20 at 9 15 07 AM

@nickmarden
Copy link

@vicente-ramos This gem repo is different from many of the others that you've been working on because it is a public repo that is published to a public gem server.

I'm not sure if we need to add support for pushing this gem to Packagecloud or Artifactory if we can push it to and pull it from gemcutter.org or some other public repository. Please research and determine if this PR is even needed. In the future you can review whether the repo is public prior to beginning your PLTF-1607 upgrades. We can discuss the ones that are public to decide whether and how to proceed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants