From 65ca9dfda718ab7aedf36c7b994829d47e56c664 Mon Sep 17 00:00:00 2001
From: Justin Shih <36183898+Jshhhh@users.noreply.github.com>
Date: Fri, 2 Sep 2022 10:32:01 -0700
Subject: [PATCH] fix: make override keys optional (#622)

Co-authored-by: Justin Shih <jushih@amazon.com>
---
 ...studio-ui-codegen-react-forms.test.ts.snap | 110 +++++++++---------
 .../lib/forms/form-renderer-helper.ts         |   6 +-
 2 files changed, 58 insertions(+), 58 deletions(-)

diff --git a/packages/codegen-ui-react/lib/__tests__/__snapshots__/studio-ui-codegen-react-forms.test.ts.snap b/packages/codegen-ui-react/lib/__tests__/__snapshots__/studio-ui-codegen-react-forms.test.ts.snap
index 08e5e1c74..f5f77b0da 100644
--- a/packages/codegen-ui-react/lib/__tests__/__snapshots__/studio-ui-codegen-react-forms.test.ts.snap
+++ b/packages/codegen-ui-react/lib/__tests__/__snapshots__/studio-ui-codegen-react-forms.test.ts.snap
@@ -228,15 +228,15 @@ export declare type CustomDataFormInputValues = {
     category: string;
 };
 export declare type CustomDataFormOverridesProps = {
-    CustomDataFormGrid: GridProps;
-    RowGrid0: GridProps;
-    name: TextFieldProps;
-    RowGrid1: GridProps;
-    email: TextFieldProps;
-    RowGrid2: GridProps;
-    city: SelectFieldProps;
-    RowGrid3: GridProps;
-    category: RadioGroupFieldProps;
+    CustomDataFormGrid?: GridProps;
+    RowGrid0?: GridProps;
+    name?: TextFieldProps;
+    RowGrid1?: GridProps;
+    email?: TextFieldProps;
+    RowGrid2?: GridProps;
+    city?: SelectFieldProps;
+    RowGrid3?: GridProps;
+    category?: RadioGroupFieldProps;
 } & EscapeHatchProps;
 export declare type CustomDataFormProps = React.PropsWithChildren<{
     overrides?: CustomDataFormOverridesProps | undefined | null;
@@ -414,15 +414,15 @@ export declare type CustomWithSectionalElementsInputValues = {
     name: string;
 };
 export declare type CustomWithSectionalElementsOverridesProps = {
-    CustomWithSectionalElementsGrid: GridProps;
-    RowGrid0: GridProps;
-    myHeading: HeadingProps;
-    RowGrid1: GridProps;
-    name: TextFieldProps;
-    RowGrid2: GridProps;
-    myText: TextProps;
-    RowGrid3: GridProps;
-    myDivider: DividerProps;
+    CustomWithSectionalElementsGrid?: GridProps;
+    RowGrid0?: GridProps;
+    myHeading?: HeadingProps;
+    RowGrid1?: GridProps;
+    name?: TextFieldProps;
+    RowGrid2?: GridProps;
+    myText?: TextProps;
+    RowGrid3?: GridProps;
+    myDivider?: DividerProps;
 } & EscapeHatchProps;
 export declare type CustomWithSectionalElementsProps = React.PropsWithChildren<{
     overrides?: CustomWithSectionalElementsOverridesProps | undefined | null;
@@ -644,15 +644,15 @@ export declare type MyPostFormInputValues = {
     profile_url: string;
 };
 export declare type MyPostFormOverridesProps = {
-    MyPostFormGrid: GridProps;
-    RowGrid0: GridProps;
-    caption: TextFieldProps;
-    RowGrid1: GridProps;
-    username: TextFieldProps;
-    RowGrid2: GridProps;
-    post_url: TextFieldProps;
-    RowGrid3: GridProps;
-    profile_url: TextFieldProps;
+    MyPostFormGrid?: GridProps;
+    RowGrid0?: GridProps;
+    caption?: TextFieldProps;
+    RowGrid1?: GridProps;
+    username?: TextFieldProps;
+    RowGrid2?: GridProps;
+    post_url?: TextFieldProps;
+    RowGrid3?: GridProps;
+    profile_url?: TextFieldProps;
 } & EscapeHatchProps;
 export declare type MyPostFormProps = React.PropsWithChildren<{
     overrides?: MyPostFormOverridesProps | undefined | null;
@@ -947,17 +947,17 @@ export declare type MyPostFormInputValues = {
     post_url: string;
 };
 export declare type MyPostFormOverridesProps = {
-    MyPostFormGrid: GridProps;
-    RowGrid0: GridProps;
-    TextAreaFieldbbd63464: TextAreaFieldProps;
-    RowGrid1: GridProps;
-    caption: TextFieldProps;
-    RowGrid2: GridProps;
-    username: TextFieldProps;
-    RowGrid3: GridProps;
-    profile_url: TextFieldProps;
-    RowGrid4: GridProps;
-    post_url: TextFieldProps;
+    MyPostFormGrid?: GridProps;
+    RowGrid0?: GridProps;
+    TextAreaFieldbbd63464?: TextAreaFieldProps;
+    RowGrid1?: GridProps;
+    caption?: TextFieldProps;
+    RowGrid2?: GridProps;
+    username?: TextFieldProps;
+    RowGrid3?: GridProps;
+    profile_url?: TextFieldProps;
+    RowGrid4?: GridProps;
+    post_url?: TextFieldProps;
 } & EscapeHatchProps;
 export declare type MyPostFormProps = React.PropsWithChildren<{
     overrides?: MyPostFormOverridesProps | undefined | null;
@@ -1300,23 +1300,23 @@ export declare type InputGalleryCreateFormInputValues = {
     timeisnow: string;
 };
 export declare type InputGalleryCreateFormOverridesProps = {
-    InputGalleryCreateFormGrid: GridProps;
-    RowGrid0: GridProps;
-    num: TextFieldProps;
-    RowGrid1: GridProps;
-    rootbeer: TextFieldProps;
-    RowGrid2: GridProps;
-    attend: RadioGroupFieldProps;
-    RowGrid3: GridProps;
-    maybeSlide: ToggleButtonProps;
-    RowGrid4: GridProps;
-    maybeCheck: CheckboxFieldProps;
-    RowGrid5: GridProps;
-    timestamp: TextFieldProps;
-    RowGrid6: GridProps;
-    ippy: TextFieldProps;
-    RowGrid7: GridProps;
-    timeisnow: TextFieldProps;
+    InputGalleryCreateFormGrid?: GridProps;
+    RowGrid0?: GridProps;
+    num?: TextFieldProps;
+    RowGrid1?: GridProps;
+    rootbeer?: TextFieldProps;
+    RowGrid2?: GridProps;
+    attend?: RadioGroupFieldProps;
+    RowGrid3?: GridProps;
+    maybeSlide?: ToggleButtonProps;
+    RowGrid4?: GridProps;
+    maybeCheck?: CheckboxFieldProps;
+    RowGrid5?: GridProps;
+    timestamp?: TextFieldProps;
+    RowGrid6?: GridProps;
+    ippy?: TextFieldProps;
+    RowGrid7?: GridProps;
+    timeisnow?: TextFieldProps;
 } & EscapeHatchProps;
 export declare type InputGalleryCreateFormProps = React.PropsWithChildren<{
     overrides?: InputGalleryCreateFormOverridesProps | undefined | null;
diff --git a/packages/codegen-ui-react/lib/forms/form-renderer-helper.ts b/packages/codegen-ui-react/lib/forms/form-renderer-helper.ts
index 125380e73..bb7856061 100644
--- a/packages/codegen-ui-react/lib/forms/form-renderer-helper.ts
+++ b/packages/codegen-ui-react/lib/forms/form-renderer-helper.ts
@@ -680,7 +680,7 @@ export const buildOverrideTypesBindings = (
     factory.createPropertySignature(
       undefined,
       factory.createIdentifier(`${formComponent.name}Grid`),
-      undefined,
+      factory.createToken(SyntaxKind.QuestionToken),
       factory.createTypeReferenceNode(factory.createIdentifier('GridProps'), undefined),
     ),
   ];
@@ -690,7 +690,7 @@ export const buildOverrideTypesBindings = (
       factory.createPropertySignature(
         undefined,
         factory.createIdentifier(`RowGrid${index}`),
-        undefined,
+        factory.createToken(SyntaxKind.QuestionToken),
         factory.createTypeReferenceNode(factory.createIdentifier('GridProps'), undefined),
       ),
     );
@@ -700,7 +700,7 @@ export const buildOverrideTypesBindings = (
         factory.createPropertySignature(
           undefined,
           factory.createIdentifier(field),
-          undefined,
+          factory.createToken(SyntaxKind.QuestionToken),
           factory.createTypeReferenceNode(factory.createIdentifier(componentTypePropName), undefined),
         ),
       );