From ad12fa8eb1db447f27d9a65bcdeac984941a24f0 Mon Sep 17 00:00:00 2001 From: Chenwei Zhang Date: Wed, 14 Feb 2024 23:56:04 +0000 Subject: [PATCH] fix: fix code scanning alerts --- .../datastore-create-form-with-belongs-to/MemberCreateForm.jsx | 2 +- .../SchoolUpdateForm.jsx | 2 +- commitlint.config.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/codegen-ui-golden-files/lib/react/forms/datastore-create-form-with-belongs-to/MemberCreateForm.jsx b/codegen-ui-golden-files/lib/react/forms/datastore-create-form-with-belongs-to/MemberCreateForm.jsx index bb40ce4c4..d39815d46 100644 --- a/codegen-ui-golden-files/lib/react/forms/datastore-create-form-with-belongs-to/MemberCreateForm.jsx +++ b/codegen-ui-golden-files/lib/react/forms/datastore-create-form-with-belongs-to/MemberCreateForm.jsx @@ -50,7 +50,7 @@ function ArrayField({ setSelectedBadgeIndex(undefined); }; const addItem = async () => { - if ((currentFieldValue !== undefined || currentFieldValue !== null || currentFieldValue !== '') && !hasError) { + if ((currentFieldValue !== undefined || currentFieldValue !== '') && !hasError) { const newItems = [...items]; if (selectedBadgeIndex !== undefined) { newItems[selectedBadgeIndex] = currentFieldValue; diff --git a/codegen-ui-golden-files/lib/react/forms/datastore-update-form-with-has-many-relationship/SchoolUpdateForm.jsx b/codegen-ui-golden-files/lib/react/forms/datastore-update-form-with-has-many-relationship/SchoolUpdateForm.jsx index 39f476c9b..1e6be675c 100644 --- a/codegen-ui-golden-files/lib/react/forms/datastore-update-form-with-has-many-relationship/SchoolUpdateForm.jsx +++ b/codegen-ui-golden-files/lib/react/forms/datastore-update-form-with-has-many-relationship/SchoolUpdateForm.jsx @@ -44,7 +44,7 @@ function ArrayField({ setSelectedBadgeIndex(undefined); }; const addItem = async () => { - if ((currentFieldValue !== undefined || currentFieldValue !== null || currentFieldValue !== '') && !hasError) { + if ((currentFieldValue !== undefined || currentFieldValue !== '') && !hasError) { const newItems = [...items]; if (selectedBadgeIndex !== undefined) { newItems[selectedBadgeIndex] = currentFieldValue; diff --git a/commitlint.config.js b/commitlint.config.js index 3203f174b..42238389f 100644 --- a/commitlint.config.js +++ b/commitlint.config.js @@ -5,7 +5,7 @@ const { module.exports = { extends: ['@commitlint/config-conventional', '@commitlint/config-lerna-scopes'], rules: { - 'scope-enum': async (context) => [2, 'always', [...(await getPackages(context)), 'release', 'deps']], + 'scope-enum': async (context) => [2, 'always', [...(await getPackages(context)), 'release', 'deps', 'deps-dev']], 'header-max-length': [2, 'always', 200], }, };