Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump amplify-android dep to 1.37.10 #2556

Merged
merged 1 commit into from
Jan 11, 2023
Merged

chore: bump amplify-android dep to 1.37.10 #2556

merged 1 commit into from
Jan 11, 2023

Conversation

fjnoyp
Copy link
Contributor

@fjnoyp fjnoyp commented Jan 9, 2023

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@fjnoyp fjnoyp requested a review from a team as a code owner January 9, 2023 20:05
@fjnoyp fjnoyp self-assigned this Jan 10, 2023
HuiSF
HuiSF previously approved these changes Jan 10, 2023
dnys1
dnys1 previously approved these changes Jan 10, 2023
@dnys1
Copy link
Contributor

dnys1 commented Jan 10, 2023

Looks like some tests need to be updated @fjnoyp due to changes in a public Android API

@fjnoyp fjnoyp dismissed stale reviews from dnys1 and HuiSF via a179fed January 10, 2023 23:15
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

Codecov Report

Merging #2556 (a179fed) into main (8fb11ed) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2556   +/-   ##
=======================================
  Coverage   46.01%   46.01%           
=======================================
  Files         364      364           
  Lines       11028    11028           
=======================================
  Hits         5074     5074           
  Misses       5954     5954           
Flag Coverage Δ
android-unit-tests ∅ <ø> (∅)
flutter-unit-tests 35.67% <ø> (ø)
ios-unit-tests 89.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@fjnoyp fjnoyp requested review from dnys1 and HuiSF January 11, 2023 02:40
@dnys1 dnys1 merged commit 2a7caae into aws-amplify:main Jan 11, 2023
dnys1 pushed a commit to dnys1/amplify-flutter that referenced this pull request Jan 11, 2023
dnys1 pushed a commit to dnys1/amplify-flutter that referenced this pull request Jan 11, 2023
## Fixes
- fix(datastore): prevent unhandled exception crashing App rebuilding sync expression (aws-amplify#2549)
- fix(datastore): Upgrading from Datastore 0.6.1 to 0.6.8 causes Android app to crash (aws-amplify#2556)

## Cherry Picks
- 160674d
- 7121ebc
- 957d6b4
- 5ec55b9
- 33df283
- 5ec023b
- 51f5e56
- fab55ae
- 6bd4182
- 6464555
- 2a7caae
@dnys1 dnys1 mentioned this pull request Jan 11, 2023
dnys1 pushed a commit to dnys1/amplify-flutter that referenced this pull request Jan 11, 2023
## Fixes
- fix(datastore): prevent unhandled exception crashing App rebuilding sync expression (aws-amplify#2549)
- fix(datastore): Upgrading from Datastore 0.6.1 to 0.6.8 causes Android app to crash (aws-amplify#2556)

## Cherry Picks
- 160674d
- 7121ebc
- 957d6b4
- 5ec55b9
- 33df283
- 5ec023b
- 51f5e56
- fab55ae
- 6bd4182
- 6464555
- 2a7caae
dnys1 pushed a commit to dnys1/amplify-flutter that referenced this pull request Jan 12, 2023
- fix(datastore): prevent unhandled exception crashing App rebuilding sync expression (aws-amplify#2549)
- fix(datastore): Upgrading from Datastore 0.6.1 to 0.6.8 causes Android app to crash (aws-amplify#2556)
- fix(api): model helpers use targetNames in schemas with CPK enabled (aws-amplify#2559)

- 160674d
- 7121ebc
- 957d6b4
- 5ec55b9
- 33df283
- 5ec023b
- 51f5e56
- fab55ae
- 6bd4182
- 6464555
- 2a7caae
- 809190c
dnys1 pushed a commit that referenced this pull request Jan 12, 2023
dnys1 pushed a commit that referenced this pull request Jan 12, 2023
- fix(datastore): prevent unhandled exception crashing App rebuilding sync expression (#2549)
- fix(datastore): Upgrading from Datastore 0.6.1 to 0.6.8 causes Android app to crash (#2556)
- fix(api): model helpers use targetNames in schemas with CPK enabled (#2559)

- 160674d
- 7121ebc
- 957d6b4
- 5ec55b9
- 33df283
- 5ec023b
- 51f5e56
- fab55ae
- 6bd4182
- 6464555
- 2a7caae
- 809190c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants