fix(notifications): configure call hangs on Flutter app hot restart #3013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add requestInitialToken native API to be called within configure and not relying on App life cycle, where when the configure is called again after Flutter app restarted, the plugin can receive token normally
HuiSF
force-pushed
the
hui/fix/notifications/token-hangs-configure
branch
from
5add634 to
0d55802
Compare
dnys1
reviewed
May 5, 2023
| deviceToken = await _bufferedTokenStream.peek; | ||
| await _hostApi.requestInitialToken(); | ||
| deviceToken = | ||
| await _bufferedTokenStream.peek.timeout(const Duration(seconds: 2)); |
There was a problem hiding this comment.
Is 2 seconds long enough? Can we make it 5 or 10 to be safe?
There was a problem hiding this comment.
On iOS and Android token generation is client behavior, and doesn't require network round trip... it should be quick. But can increase the timeout surely to avoid surprises, as this timeout is for catching potential error without increasing latency for normal use cases. Will update to 5.
dnys1
approved these changes
May 5, 2023
Samaritan1011001
approved these changes
May 8, 2023
dnys1
pushed a commit
that referenced
this pull request
May 9, 2023
## 1.1.0 ### Features - Dart 3 support (must update SDK constraint to `^3.0.0-417.4.beta`) - feat(core): add granular model read operations ([#2611](#2611)) ### Fixes - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 9, 2023
## 1.1.0 ### Features - Dart 3 support (must update SDK constraint to `^3.0.0-417.4.beta`) - feat(core): add granular model read operations ([#2611](#2611)) ### Fixes - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 9, 2023
## 1.1.0 ### Features - Dart 3 support (must update SDK constraint to `^3.0.0-417.4.beta`) - feat(core): add granular model read operations ([#2611](#2611)) ### Fixes - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 10, 2023
- Dart 3 support (must update SDK constraint to `^3.0.0-417.4.beta`) - feat(core): add granular model read operations ([#2611](#2611)) - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 10, 2023
- Dart 3 support (must update SDK constraint to `^3.0.0-417.4.beta`) - feat(core): add granular model read operations ([#2611](#2611)) - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 10, 2023
- Dart 3 support (must update SDK constraint to `^3.0.0-417.4.beta`) - feat(core): add granular model read operations ([#2611](#2611)) - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 10, 2023
- Dart 3 support (must update SDK constraint to `^3.0.0-417.4.beta`) - feat(core): add granular model read operations ([#2611](#2611)) - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 10, 2023
- Dart 3 support (must update SDK constraint to `^3.0.0-417.4.beta`) - feat(core): add granular model read operations ([#2611](#2611)) - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 10, 2023
- Dart 3 support (must update Dart SDK constraint to `^3.0.0`) - feat(core): add granular model read operations ([#2611](#2611)) - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 10, 2023
- Dart 3 support (must update Dart SDK constraint to `^3.0.0`) - feat(core): add granular model read operations ([#2611](#2611)) - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 11, 2023
- Dart 3 support (must update Dart SDK constraint to `^3.0.0`) - feat(core): add granular model read operations ([#2611](#2611)) - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Stivenmore
pushed a commit
to JunoLuK/amplify-flutter
that referenced
this pull request
Jun 9, 2023
…ws-amplify#3013) * fix(notifications): configure call hangs on Flutter app hot restart - add requestInitialToken native API to be called within configure and not relying on App life cycle, where when the configure is called again after Flutter app restarted, the plugin can receive token normally * Increase the timeout to 5 seconds.
Stivenmore
pushed a commit
to JunoLuK/amplify-flutter
that referenced
this pull request
Jun 9, 2023
- Dart 3 support (must update Dart SDK constraint to `^3.0.0`) - feat(core): add granular model read operations ([aws-amplify#2611](aws-amplify#2611)) - fix(notifications): configure call hangs on Flutter app hot restart ([aws-amplify#3013](aws-amplify#3013)) - fix(repo): AGP 8.0 compatibility ([aws-amplify#2942](aws-amplify#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2989
Description of changes:
Added
requestInitialTokennative API to be called within configure and not relying on App life cycle, where when the configure is called again after Flutter app hot restarted, the plugin can still receive token normally.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.