From fa568dd2e8f80b6967828abf1bd56c6ab63071e0 Mon Sep 17 00:00:00 2001 From: 0618 Date: Mon, 26 Sep 2022 14:14:00 -0700 Subject: [PATCH 1/2] fix(workflow): log failure data points --- .github/workflows/build-and-runtime-test.yml | 15 +++++++++++---- .github/workflows/publish-latest.yml | 15 +++++++++++---- .github/workflows/publish-next.yml | 13 +++++++++++-- 3 files changed, 33 insertions(+), 10 deletions(-) diff --git a/.github/workflows/build-and-runtime-test.yml b/.github/workflows/build-and-runtime-test.yml index 90b856f6a52..ed7335c9500 100644 --- a/.github/workflows/build-and-runtime-test.yml +++ b/.github/workflows/build-and-runtime-test.yml @@ -135,14 +135,14 @@ jobs: AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} AWS_REGION: us-east-1 - log-metric: - # Send data point to metric BuildAndRuntimeTestFailure in github-workflows@ us-east-2, if it's a failure + log-failure-metric: + # Send a failure data point to metric BuildAndRuntimeTestFailure in github-workflows@ us-east-2, if it's a failure runs-on: ubuntu-latest environment: ci needs: build + if: ${{ failure() }} steps: - name: Log failure data point to metric BuildAndRuntimeTestFailure - if: ${{ failure() }} uses: aws-amplify/amplify-ui/.github/actions/log-metric@main with: metric-name: BuildAndRuntimeTestFailure @@ -150,8 +150,15 @@ jobs: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID_METRIC_LOGGER }} AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY_METRIC_LOGGER }} AWS_REGION: us-east-2 + + log-success-metric: + # Send a success data point to metric BuildAndRuntimeTestFailure in github-workflows@ us-east-2, if it's a success + runs-on: ubuntu-latest + environment: ci + needs: build + if: ${{ success() }} + steps: - name: Log success data point to metric BuildAndRuntimeTestFailure - if: ${{ success() }} uses: aws-amplify/amplify-ui/.github/actions/log-metric@main with: metric-name: BuildAndRuntimeTestFailure diff --git a/.github/workflows/publish-latest.yml b/.github/workflows/publish-latest.yml index 3bb496fdb76..daa3e3268ac 100644 --- a/.github/workflows/publish-latest.yml +++ b/.github/workflows/publish-latest.yml @@ -139,14 +139,14 @@ jobs: AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} AWS_REGION: us-east-1 - log-metric: - # Send data point to metric PublishLatestFailure in github-workflows@ us-east-2 + log-failure-metric: + # Send a failure data point to metric PublishLatestFailure in github-workflows@ us-east-2 runs-on: ubuntu-latest environment: ci needs: publish + if: ${{ failure() }} steps: - name: Log failure data point to metric PublishLatestFailure - if: ${{ failure() }} uses: aws-amplify/amplify-ui/.github/actions/log-metric@main with: metric-name: PublishLatestFailure @@ -154,8 +154,15 @@ jobs: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID_METRIC_LOGGER }} AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY_METRIC_LOGGER }} AWS_REGION: us-east-2 + + log-success-metric: + # Send a success data point to metric PublishLatestFailure in github-workflows@ us-east-2 + runs-on: ubuntu-latest + environment: ci + needs: publish + if: ${{ success() }} + steps: - name: Log success data point to metric PublishLatestFailure - if: ${{ success() }} uses: aws-amplify/amplify-ui/.github/actions/log-metric@main with: metric-name: PublishLatestFailure diff --git a/.github/workflows/publish-next.yml b/.github/workflows/publish-next.yml index 08a4db70e11..7d422204342 100644 --- a/.github/workflows/publish-next.yml +++ b/.github/workflows/publish-next.yml @@ -182,11 +182,12 @@ jobs: AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} AWS_REGION: us-east-1 - log-metric: - # Send data point to metric PublishNextFailure in github-workflows@ us-east-2, if it's a failure + log-failure-metric: + # Send a failure data point to metric PublishNextFailure in github-workflows@ us-east-2, if it's a failure runs-on: ubuntu-latest environment: ci needs: build-test + if: ${{ failure() }} steps: - name: Log failure data point to metric PublishNextFailure if: ${{ failure() }} @@ -197,6 +198,14 @@ jobs: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID_METRIC_LOGGER }} AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY_METRIC_LOGGER }} AWS_REGION: us-east-2 + + log-success-metric: + # Send a success data point to metric PublishNextFailure in github-workflows@ us-east-2, if it's a success + runs-on: ubuntu-latest + environment: ci + needs: build-test + if: ${{ success() }} + steps: - name: Log success data point to metric PublishNextFailure if: ${{ success() }} uses: aws-amplify/amplify-ui/.github/actions/log-metric@main From cec147607d01fa8625bf72eafefffdbdca77d084 Mon Sep 17 00:00:00 2001 From: 0618 Date: Mon, 26 Sep 2022 14:16:08 -0700 Subject: [PATCH 2/2] fix(workflow): rename to Build and Runtime Test --- .github/workflows/build-and-runtime-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-and-runtime-test.yml b/.github/workflows/build-and-runtime-test.yml index ed7335c9500..8c3e7e8ca36 100644 --- a/.github/workflows/build-and-runtime-test.yml +++ b/.github/workflows/build-and-runtime-test.yml @@ -3,7 +3,7 @@ # # Triggered by: it runs every 15 minutes. -name: Run and Test Builds +name: Build and Runtime Test on: schedule: