Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] chore(storage-browser) - add correct table cell truncation styling to text cells #5683

Draft
wants to merge 2 commits into
base: feat-storage-browser/main
Choose a base branch
from

Conversation

hbuchel
Copy link
Contributor

@hbuchel hbuchel commented Aug 26, 2024

Description of changes

Adds back the missing wrapper for text cells in LocationsView table

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hbuchel hbuchel requested a review from a team as a code owner August 26, 2024 20:00
Copy link

changeset-bot bot commented Aug 26, 2024

⚠️ No Changeset found

Latest commit: 22d480f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

calebpollman
calebpollman previously approved these changes Aug 26, 2024
timngyn
timngyn previously approved these changes Aug 26, 2024
@hbuchel hbuchel dismissed stale reviews from timngyn and calebpollman via 22d480f August 26, 2024 20:34
@hbuchel hbuchel marked this pull request as draft August 26, 2024 21:05
@hbuchel hbuchel changed the title Add missing class to text cells [WIP] chore(storage-browser) - add correct table cell truncation styling to text cells Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants