Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Added error messaging when region is undefined #59

Merged
merged 2 commits into from
Oct 21, 2021
Merged

chore: Added error messaging when region is undefined #59

merged 2 commits into from
Oct 21, 2021

Conversation

thaddmt
Copy link
Contributor

@thaddmt thaddmt commented Oct 19, 2021

Description of changes

  • Throws an error when region is undefined when creating Location Service URLs

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are [changed or added]
  • Relevant documentation is changed or added (and PR referenced)

@thaddmt thaddmt requested a review from TreTuna October 19, 2021 17:27
@thaddmt @mojodna
Update src/AmplifyMapLibreRequest.ts
8d9fdc7 
Co-authored-by: Seth Fitzsimmons <seth@mojodna.net>
@thaddmt thaddmt merged commit 898a565 into aws-amplify:main Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mojodna mojodna mojodna left review comments

@TreTuna TreTuna TreTuna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thaddmt @mojodna @TreTuna