Skip to content

Add a comment to indicate that the customSetDefaults fix is a temporary workaround #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2021
Merged

Add a comment to indicate that the customSetDefaults fix is a temporary workaround #19

merged 1 commit into from
Jun 25, 2021

Conversation

@mbaijal
Copy link
Contributor

@mbaijal mbaijal commented Jun 3, 2021

Add a comment to indicate that the customSetDefaults fix is a temporary workaround.
PR #12 is intended to be reverted in the future.

@ack-bot ack-bot requested review from jaypipes and vijtrip2 June 3, 2021 20:29
@mbaijal mbaijal requested a review from surajkota June 3, 2021 20:31
@surajkota
Copy link
Contributor

surajkota commented Jun 3, 2021

/test
/approve

@ack-bot
Copy link
Collaborator

ack-bot commented Jun 3, 2021

@surajkota: The /test command needs one or more targets.
The following commands are available to trigger jobs:

  • /test applicationautoscaling-kind-e2e
  • /test applicationautoscaling-unit-test

In response to this:

/test
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@surajkota
Copy link
Contributor

surajkota commented Jun 3, 2021

/test applicationautoscaling-kind-e2e
/test applicationautoscaling-unit-test

jaypipes
jaypipes approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :)

@mbaijal
Copy link
Contributor Author

mbaijal commented Jun 25, 2021

/retest

@surajkota
Copy link
Contributor

surajkota commented Jun 25, 2021

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Jun 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypipes, mbaijal, surajkota

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jaypipes,mbaijal,surajkota]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit d5d10d9 into aws-controllers-k8s:main Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vijtrip2 vijtrip2 Awaiting requested review from vijtrip2

@surajkota surajkota Awaiting requested review from surajkota

1 more reviewer

@jaypipes jaypipes jaypipes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@surajkota surajkota

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mbaijal @surajkota @ack-bot @jaypipes