Skip to content

Conversation

@dajudge
Copy link
Contributor

@dajudge dajudge commented Jan 18, 2022

At the moment, the helm chart treats the deployment's tolerations as an object (similarly to nodeSelector). In the Deployment manifest however tolerations are an array (in contrast to nodeSelector). This PR makes the deployment's tolerations of type array instead of object.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested review from jaypipes and vijtrip2 January 18, 2022 14:38
@ack-bot ack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 18, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Jan 18, 2022

Hi @dajudge. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch @dajudge thank you!

@jaypipes
Copy link
Collaborator

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Jan 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dajudge, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 89b0a10 into aws-controllers-k8s:main Jan 18, 2022
@dajudge
Copy link
Contributor Author

dajudge commented Jan 19, 2022

@jaypipes thanks for the super fast reaction!

you don't have by any chance a hint on a possible date for a release that incorporates this PR? we're using RDS controller in a setup where we rely on nodeSelectors/tolerations a lot...

@jaypipes
Copy link
Collaborator

@jaypipes thanks for the super fast reaction!

you don't have by any chance a hint on a possible date for a release that incorporates this PR? we're using RDS controller in a setup where we rely on nodeSelectors/tolerations a lot...

We're currently trying to fix a critical bug (aws-controllers-k8s/community#1133). Will cut a release after that fix. Hoping to get one out by EOW. Thanks for your patience!

@dajudge dajudge deleted the fix-tolerations branch June 25, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants