adding operator-sdk to the code-generator /bin folder #305
Conversation
|
Hi @acornett21. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ack-bot
added
the
needs-ok-to-test
|
@komish LMK what you think. |
RedbackThomson
left a comment
RedbackThomson
left a comment
There was a problem hiding this comment.
Just a small nit regarding consistency in naming
|
@acornett21 I also added a few nits, and they're mostly inline with existing comments so I didn't submit a formal "request changes". Mostly documentation. |
…to generate the bundle this allows for the user to have one version locally but pin this project to a known working version Signed-off-by: Adam D. Cornett <adc@redhat.com>
acornett21
force-pushed
the
use_project_local_operator_sdk
branch
from
e49120f to
72880af
Compare
|
/ok-to-test |
ack-bot
added
ok-to-test
|
/retest |
|
@a-hilaly I raised a PR to |
|
Thanks @acornett21 , let's wait for https://github.com/aws-controllers-k8s/test-infra/pull/189/files to get merged :) |
…pts (#189) Issue #, if available: - Relates: aws-controllers-k8s/code-generator#305 Description of changes: In order to get changes to code-generator made, the tests for OLM also need to be changed. Passing in the new env `OPERATOR_SDK_BIN_PATH` where necessary. Please let me know if I missed any places. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Adam D. Cornett <adc@redhat.com>
|
/test s3-olm-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vijtrip2 Thanks for fixing the images! |
6 participants
Issue #, if available:
N/A
Description of changes:
Since there is a change in operator-sdk that isn't compatible with the way ACK
deployment.yaml's are built, it's best if we install and use a specific version in the/binfolder of thecode-generator. This way no matter what version ofoperator-sdka developer has installed, we can control what versions are used for local development and release of this project.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Signed-off-by: Adam D. Cornett adc@redhat.com