Generate Region() method for resourceIdentifiers
#309
Conversation
a-hilaly
changed the title
Region() to ResourceMetadata struct and AWSResourceIdentifiers interfaceRegion() method for resourceIdentifiers
RedbackThomson
left a comment
RedbackThomson
left a comment
There was a problem hiding this comment.
Just one nit to bring it in-line with the latest runtime updates
a-hilaly
force-pushed
the
resource-region
branch
from
42bed9f to
537a378
Compare
|
/retest |
interface Currently when a resource is created without setting a region in the annotations, the controller uses either the namespace annotation or the controller region flag. This causes the controller to miss manage the resource if they are restart with a different region, or if run a second controller using a different region flag. This patch modifies the code-generator to generate a `Region` function so that a resource can also satisfy the `Identifiers` interface. This patch also extends the `setStatusDefaults` so that it correctly populates the status.ResourceMetadata.Region with the aws region in which it is created/managed This patch will also require some changes to the runtime repository. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
a-hilaly
force-pushed
the
resource-region
branch
from
537a378 to
9a53ab2
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes, RedbackThomson, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@a-hilaly: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5 participants
Follow up to aws-controllers-k8s/runtime#79
This patch modifies the code-generator to generate a
Regionfunctionso that a resource can also satisfy the
Identifiersinterface. Thisthe patch also extends the
setStatusDefaultsso that it correctlypopulates the
status.ResourceMetadata.Regionwith the aws region inwhich it is created/managed
Description of changes:
Region()method to resourceIdentifiers template.setStatusDefaultsto be able to set the a default region.runtime_test.goBy submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.