Fix controller ClusterRole file generation
#363
Conversation
Recently we bumped `controller-tools` version to `v0.9.2` to support building controller with go1.19. This change sneakily impacted the `build-controller-release.sh` script, which caused our prow testing jobs to fail. To summarize the bug we can generate the `role.yaml` file using controller-gen `0.7.0` and `0.9.2` and inspect the differences: ```bash diff role-controller-gen0.9.2.yaml role-controller-gen0.7.0.yaml 0a1 > ``` We can observe that the new line that used it be generated at the top of each file is no longer there, due to the fix introduced in 0.8.0 more precisely in kubernetes-sigs/controller-tools#626 This change combined with the command `tail -n +8` in https://github.com/aws-controllers-k8s/code-generator/blob/v0.20.0/scripts/build-controller-release.sh#L237 causes the script to cut an extra line which happens to be declaration of rules section in a controller ClusterRole manifest. Hence the error observed in the prow logs: ```bash Error: INSTALLATION FAILED: YAML parse error on emrcontainers-chart/templates/cluster-role-controller.yaml: error converting YAML to JSON: yaml: line 8: did not find expected key ``` This patch fixes the `tail` command to properly cut the generated `role.yaml` file and avoid deleteng the `rules` section.
|
@a-hilaly: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Wow what a great catch. Well done! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
This patch fixes the
tailcommand to properly cut the generatedrole.yamlfile and avoid deleteng therulessection.Context:
Recently we bumped
controller-toolsversion tov0.9.2to supportbuilding controller with go1.19. This change sneakily impacted the
build-controller-release.shscript, which caused our prow testing jobsto fail.
To summarize the bug we can generate the
role.yamlfile usingcontroller-gen
0.7.0and0.9.2and inspect the differences:diff role-controller-gen0.9.2.yaml role-controller-gen0.7.0.yaml 0a1 >We can observe that the new line that used it be generated at the top of
each file is no longer there, due to the fix introduced in 0.8.0 more
precisely in kubernetes-sigs/controller-tools#626
This change combined with the command
tail -n +8in the buildcontroller release script causes the script to cut an extra line which
happens to be declaration of rules section in a controller ClusterRole
manifest. Hence the error observed in the prow logs:
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.