Unhandled case in `equalStrings` function implementation

[a-hilaly]

The equalStrings function in most of (if not all) hooks.go files compares two string pointers and returns whether they are equal or not while taking into consideration that a nil pointer and an empty string are equal. However, there is a case that is not being handled correctly in the current implementation. As a result, the function may not return the expected result
Here is the implementation:

func equalStrings(a, b *string) bool {
	if a == nil {
		return b == nil || *b == ""
	}
	return (*a == "" && b == nil) || *a == *b
}

Again thank you @embano1 for spotting this!

[jaypipes]

However, there is a case that is not being handled correctly in the current implementation.

What case is not being handled?

[a-hilaly]

What case is not being handled?

*a != "" && b == nil. Correct implementation should be something like:

func equalStrings(a, b *string) bool {
	if a == nil {
		return b == nil
	} else if b == nil {
		return false
	}
	return *a == *b
}

[ack-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale