-
Notifications
You must be signed in to change notification settings - Fork 149
go 1.17 upgrade for prow images #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RedbackThomson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RedbackThomson, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes: * include updating go module version inside `go.mod` file alongwith updating ACK runtime version * perform `go mod download` and `go mod tidy` before executing `make build-controller` command * update `go` version to `1.17.5` in all prow images * use github utility functions for opening PR and issues inside `auto-generate-controllers.sh` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description of changes:
go.modfile alongwith updating ACK runtime versiongo mod downloadandgo mod tidybefore executingmake build-controllercommandgoversion to1.17.5in all prow imagesauto-generate-controllers.shBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.