Skip to content

Conversation

@vijtrip2
Copy link
Contributor

@vijtrip2 vijtrip2 commented Jan 7, 2022

Description of changes:

  • include updating go module version inside go.mod file alongwith updating ACK runtime version
  • perform go mod download and go mod tidy before executing make build-controller command
  • update go version to 1.17.5 in all prow images
  • use github utility functions for opening PR and issues inside auto-generate-controllers.sh

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@RedbackThomson RedbackThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Jan 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RedbackThomson, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RedbackThomson,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit c7ed7dd into aws-controllers-k8s:main Jan 7, 2022
RedbackThomson pushed a commit to RedbackThomson/ack-test-infra that referenced this pull request Jan 8, 2022
Description of changes:

* include updating go module version inside `go.mod` file alongwith updating ACK runtime version
* perform `go mod download` and `go mod tidy` before executing `make build-controller` command
* update `go` version to `1.17.5` in all prow images
* use github utility functions for opening PR and issues inside `auto-generate-controllers.sh`


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants