Create ack-system namespace before applying RBAC test resources
#177
Conversation
…ng `kubectl apply` on the RBAC folder, since a service account is now being created in that folder Signed-off-by: Adam D. Cornett <adc@redhat.com>
| done | ||
| echo "ok." | ||
|
|
||
| echo -n "creating ack-system namespace" |
There was a problem hiding this comment.
One questions:
deployment.yamlfile in kustomize tries tokubectl applyack-systemnamespace again? Did you any error/warning for that when running test locally?
There was a problem hiding this comment.
Kustomize doesn't care - it just overwrites it with the same value.
There was a problem hiding this comment.
@vijtrip2 What @RedbackThomson said is correct, since this is creating the namespace the same way as in the deployment.yaml there aren't any issues/warnings/errors. Below are the logs for clarity, meant to add them to the PR but forgot.
creating ack-system namespacenamespace/ack-system created
loading RBAC manifests for s3 into the cluster ... ok.
loading service controller Deployment for s3 into the cluster ...ok.
| apiVersion: kind.x-k8s.io/v1alpha4 | ||
| nodes: | ||
| - role: control-plane | ||
| kubeadmConfigPatches: |
There was a problem hiding this comment.
any reason for removing this?
There was a problem hiding this comment.
Adam and I were trying to debug an issue with his KIND cluster not being created properly. I noticed this unnecessary config patch for the cluster and we deleted it just to make sure it wasn't affecting him. It's not necessary for the e2e tests, so we figured we'd just leave it out.
| K8_1_16="kindest/node:v1.16.9@sha256:7175872357bc85847ec4b1aba46ed1d12fa054c83ac7a8a11f5c268957fd5765" | ||
| K8_1_15="kindest/node:v1.15.11@sha256:6cc31f3533deb138792db2c7d1ffc36f7456a06f1db5556ad3b6927641016f50" | ||
| K8_1_14="kindest/node:v1.14.10@sha256:6cd43ff41ae9f02bb46c8f455d5323819aec858b99534a290517ebc181b443c6" | ||
| K8_1_21="kindest/node:v1.21.1" |
RedbackThomson
changed the title
kubectl apply on the RBAC folderack-system namespace before applying RBAC test resources
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, RedbackThomson, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Issue #, if available:
defaultin generated kustomize manifests community#777Description of changes:
This pull request is needed to get tests to pass for
It also removes
shainformation from k8's versions, since thisshaversion is not static. Meaning that k8s can and does update a sha for a given version to fix security updates and some of theseshascan no longer be pulled locally.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Signed-off-by: Adam D. Cornett adc@redhat.com