Merge pull request #69 from CrowdStrike/FIX-ssm-action

bugfix - action case
aws-ia · Oct 21, 2024 · 2f3640f · 2f3640f
2 parents ec58293 + 66a0dd6
commit 2f3640f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/templates/crowdstrike_init_stack.yaml b/templates/crowdstrike_init_stack.yaml
@@ -434,7 +434,7 @@ Resources:
         - ParameterKey: SecretStorageMethod
           ParameterValue: 'SecretsManager'
         - ParameterKey: Action
-          ParameterValue: 'install'
+          ParameterValue: 'Install'
         - ParameterKey: ScheduleExpression
           ParameterValue: !Ref ScheduleExpression
         - ParameterKey: MaxErrors
@@ -1200,14 +1200,14 @@ Resources:
                   print(('key = %s' %key))
                   s3.copy_object(CopySource=copy_source, Bucket=dest_bucket,
                       Key=key)
-          def bucket_exists():
+          def bucket_exists(bucket):
               s3 = boto3.client('s3')
               buckets = s3.list_buckets()
-              for bucket in buckets['Buckets']:
+              if bucket in buckets['Buckets']:
                   return True
           def delete_objects(bucket, prefix, objects):
               s3 = boto3.client('s3')
-              if bucket_exists():
+              if bucket_exists(bucket):
                   objects = {'Objects': [{'Key': prefix + o} for o in objects]}
                   s3.delete_objects(Bucket=bucket, Delete=objects)
           def timeout(event, context):

diff --git a/templates/ssm-association-stackset.yml b/templates/ssm-association-stackset.yml
@@ -9,7 +9,7 @@ Parameters:
   Action:
     Description: Specify whether or not to install or uninstall the package.
     Type: String
-    AllowedValues: [ "install", "uninstall"]
+    AllowedValues: [ "Install", "Uninstall"]
   SecretStorageMethod:
     Description: The method used to store the FalconClientId, FalconClientSecret, and FalconCloud for the CrowdStrike APIs.
     Type: String