Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lambda cfn #2

Merged
merged 8 commits into from
Oct 23, 2024
Merged

remove lambda cfn #2

merged 8 commits into from
Oct 23, 2024

Conversation

eistrati
Copy link
Collaborator

No description provided.

Copy link

Hi there,

I am commenting because your project has not yet been published and you have opened a pr to the main branch.

If you are ready to publish, please issue the following comment on this PR and I will initiate the publication review
process:

/confirm-publication

If you require more information please reach out to your AWS contact assisting you with this project.

@eistrati
Copy link
Collaborator Author

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

@eistrati
Copy link
Collaborator Author

/confirm-publication

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review has been requested from required contributors, once they have approved I will remove my request for changes. When this PR is merged your project will be published

@wellsiau-aws
Copy link
Collaborator

/do-e2e-tests

Copy link

End to end test has been scheduled

@wellsiau-aws wellsiau-aws self-assigned this Oct 23, 2024
@wellsiau-aws wellsiau-aws added the enhancement New feature or request label Oct 23, 2024
Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

Copy link
Collaborator

@wellsiau-aws wellsiau-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just small questions about the sensitive variables and the hardcoded SG

variables.tf Outdated Show resolved Hide resolved
examples/minio/minio-tenant.yaml Outdated Show resolved Hide resolved
@wellsiau-aws
Copy link
Collaborator

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

Copy link
Collaborator

@wellsiau-aws wellsiau-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wellsiau-aws wellsiau-aws merged commit dfc9d4a into main Oct 23, 2024
2 checks passed
@eistrati eistrati deleted the feature/lambda_cfn branch October 23, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants