From 0c4ee16b7efed754151505ea7ee909dbde385175 Mon Sep 17 00:00:00 2001 From: David <75678655+David-Werth@users.noreply.github.com> Date: Fri, 8 Aug 2025 12:17:43 +0200 Subject: [PATCH 1/2] refactor(commons): use nullish coalescing operator instead of ternary expression for maxSize instatiation --- packages/commons/src/LRUCache.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/commons/src/LRUCache.ts b/packages/commons/src/LRUCache.ts index 161938021b..b4482e9983 100644 --- a/packages/commons/src/LRUCache.ts +++ b/packages/commons/src/LRUCache.ts @@ -80,8 +80,7 @@ class LRUCache { * @param config - The configuration options for the cache */ public constructor(config?: LRUCacheOptions) { - this.maxSize = - config?.maxSize !== undefined ? config.maxSize : DEFAULT_MAX_SIZE; + this.maxSize = config?.maxSize ?? DEFAULT_MAX_SIZE; this.map = new Map(); } From 00f22a4742927f107519c7fae0cc6abc9cb7fd9f Mon Sep 17 00:00:00 2001 From: David <75678655+David-Werth@users.noreply.github.com> Date: Fri, 8 Aug 2025 12:18:06 +0200 Subject: [PATCH 2/2] refactor(commons): simplify union type to unknown --- packages/commons/src/types/middy.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/commons/src/types/middy.ts b/packages/commons/src/types/middy.ts index b8173d263e..e0f4251c04 100644 --- a/packages/commons/src/types/middy.ts +++ b/packages/commons/src/types/middy.ts @@ -60,7 +60,7 @@ type MiddlewareLikeObj< type MiddyLikeRequest = { event: unknown; context: Context; - response: unknown | null; + response: unknown; error: Error | null; internal: { [key: string]: unknown;