This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
Fix react query updates #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mendaomn
previously approved these changes
Aug 4, 2022
mtfranchetto
force-pushed
the
fix-react-query-updates
branch
from
f86ad26 to
b653602
Compare
mendaomn
approved these changes
Aug 4, 2022
rkilpadi
pushed a commit
to rkilpadi/pcluster-manager
that referenced
this pull request
Aug 4, 2022
* Invalidate all queries when the region is changed * Fix clusters list displayed during updates * Add tests for clusters update
BarcoMasile
added
the
release:feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an issue emerged from #219 where a user might not get a clusters list update when a region is changed. This happens because when you switch the region,
react-queryis not informed that the change happened, and the user still sees the old data.Changes
How Has This Been Tested?
PR Quality Checkilst
i18nsolution instead (see here)npm run buildbuilds without any errorBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.