Skip to content
This repository was archived by the owner on Nov 19, 2025. It is now read-only.

Conversation

@SoManyHs
Copy link
Contributor

@SoManyHs SoManyHs commented May 17, 2019

Issue #, if available:

Description of changes:


Enter [N/A] in the box, if an item is not applicable to your change.

Testing

  • Unit tests passed
  • Integration tests passed
  • Unit tests added for new functionality
  • Listed manual checks and their outputs in the comments (example)
  • [N/A] Link to issue or PR for the integration tests:

Documentation

  • [N/A] Contacted our doc writer
  • [N/A] Updated our README

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SoManyHs
Copy link
Contributor Author

SoManyHs commented May 17, 2019

make && make test pass.

~/go/src/github.com/aws/amazon-ecs-cli(local-create)$ ecs-cli local create --help
NAME:
   ecs-cli local create - Uses a Task Definition input and converts it to a docker-compose.local.yml file that can be run locally.

USAGE:
   ecs-cli local create [command options] [arguments...]

OPTIONS:
   --file value, -f value    The file name of the task definition to convert.
   --arn value, -a value     The ARN of the task definition to convert.
   --output value, -o value  The name of the file to write to. If not specified, defaults to docker-compose.local.yml
   

~/go/src/github.com/aws/amazon-ecs-cli(local-create)$ ecs-cli local create
foo // placeholder output

@SoManyHs SoManyHs requested a review from efekarakus May 17, 2019 17:04
Copy link
Contributor

@efekarakus efekarakus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just two small nit comments. Feel free to merge after addressing them.

@SoManyHs SoManyHs merged commit 73ec4f3 into aws:ecs-local May 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants