fix: when expression must be exhaustive by adding else branch #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #106
Description of changes:
In Kotlin 1.6.0, non-exhaustive
when
was marked as a compile-time warning, if used as a statement. In 1.7.0, a compile-time error is thrown to make this behaviour consistent withwhen
expressions. More info hereFor our use case, we added an empty else branch to the
when
statement onPlayer.State
.To test this, add
kotlinVersion= "1.7.0"
toandroid/build.gradle
to the example project, like so:By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.