Fix return path of NodePort traffic when using Calico network policy. #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue #75 was previously fixed in #130.
However when using aws-vpc-cni together with Calico network policy, that fix does not work, as Calico stops traversing the mangle table early and the CONNMARK rules put by the code in #130 are never reached.
This PR configures Felix (part of calico) to RETURN inside iptables mangle table instead of ACCEPT, so that the rules put by AWS VPC CNI get actually executed.
This bug was referenced in #231 (comment), although the issue was created for smth different.
iptables mangle table before this fix (note ACCEPT in cali-PREROUTING):
iptables mangle table after this fix (note RETURN in cali-PREROUTING):
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.