Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use protobuf content type instead of json for k8s client #468

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

bhavi-koduru
Copy link
Member

Issue #, if available:

Description of changes:

This MR is a part of effort to elevate single eks cluster performance by migrating the EKS components to use protobuf instead of json.

Modify kubeconfig type to use content type application/vnd.kubernetes.protobuf instead of json for performance gain.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bhavi-koduru bhavi-koduru requested a review from a team as a code owner September 12, 2024 22:25
Copy link
Contributor

@yash97 yash97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@hakuna-matatah
Copy link

/lgtm

Copy link

@mengqiy mengqiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sushrk sushrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Adding a note per other discussions- CRDs only support JSON, the fallback in the change should handle this case.

@sushrk sushrk merged commit dd3564c into aws:master Sep 16, 2024
4 checks passed
bhavi-koduru added a commit to bhavi-koduru/amazon-vpc-resource-controller-k8s that referenced this pull request Sep 25, 2024
jaydeokar pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants