Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 19, 2025

Refactor NonHotswappableChange to contain consistent, well-structured data.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain temporarily deployed to integ-approval March 19, 2025 13:42 — with GitHub Actions Inactive
@mrgrain mrgrain marked this pull request as draft March 19, 2025 13:43
auto-merge was automatically disabled March 19, 2025 13:43

Pull request was converted to draft

@mrgrain mrgrain changed the base branch from main to mrgrain/refactor/code-re-org March 19, 2025 13:43
@aws-cdk-automation aws-cdk-automation requested a review from a team March 19, 2025 13:43
@github-actions github-actions bot added the p2 label Mar 19, 2025
@mrgrain mrgrain force-pushed the mrgrain/feat/non-hotswappable-resources branch from a83bd89 to 65e0c40 Compare March 19, 2025 13:46
@mrgrain mrgrain force-pushed the mrgrain/feat/non-hotswappable-resources branch from 4ec1228 to 65e0c40 Compare March 19, 2025 15:38
@mrgrain mrgrain added pr/exempt-integ-test Skips the integ test steps if set. and removed pr/exempt-integ-test Skips the integ test steps if set. labels Mar 19, 2025
Base automatically changed from mrgrain/refactor/code-re-org to main March 19, 2025 20:21
@mrgrain mrgrain marked this pull request as ready for review March 19, 2025 20:22
@mrgrain mrgrain force-pushed the mrgrain/feat/non-hotswappable-resources branch from 65e0c40 to 0ef8307 Compare March 19, 2025 20:48
@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Mar 19, 2025
@mrgrain mrgrain closed this Mar 19, 2025
auto-merge was automatically disabled March 19, 2025 20:48

Pull request was closed

@mrgrain mrgrain reopened this Mar 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 78.46154% with 28 lines in your changes missing coverage. Please review.

Project coverage is 84.86%. Comparing base (814c45d) to head (896a9c6).

Files with missing lines Patch % Lines
...aws-cdk/lib/api/deployments/hotswap-deployments.ts 74.28% 27 Missing ⚠️
packages/aws-cdk/lib/api/hotswap/common.ts 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
+ Coverage   84.85%   84.86%   +0.01%     
==========================================
  Files         218      218              
  Lines       36530    36560      +30     
  Branches     4544     4554      +10     
==========================================
+ Hits        30998    31028      +30     
  Misses       5388     5388              
  Partials      144      144              
Flag Coverage Δ
suite.unit 84.86% <78.46%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit a3b405a Mar 20, 2025
11 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/feat/non-hotswappable-resources branch March 20, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants