Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented May 5, 2025

configuration.settings.get(['notices']) looks like it should have the correct value already and subsequently shouldDisplayNotices also implies this. But the previous code had the auto-detection logical after this and so the config could unexpectedly be undefined.

This PR fixes this by moving the auto-detection logic into yargs default parsing.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain temporarily deployed to integ-approval May 5, 2025 11:14 — with GitHub Actions Inactive
@aws-cdk-automation aws-cdk-automation requested a review from a team May 5, 2025 11:15
@github-actions github-actions bot added the p2 label May 5, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.25%. Comparing base (1d4fd87) to head (c9435c3).

Files with missing lines Patch % Lines
packages/aws-cdk/lib/cli/cli.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
+ Coverage   79.18%   79.25%   +0.06%     
==========================================
  Files          54       54              
  Lines        6895     6897       +2     
  Branches      772      772              
==========================================
+ Hits         5460     5466       +6     
+ Misses       1417     1413       -4     
  Partials       18       18              
Flag Coverage Δ
suite.unit 79.25% <77.77%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue May 5, 2025
Merged via the queue into main with commit bd4ad74 May 5, 2025
25 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/refactor/notices/auto-detect branch May 5, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants