Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanks for this context. If more options are likely to added, I'd prefer to see this as an enum like class instead of an actual enum so that it's more extensible if options or props need to be added to potential auth types. #527

Closed
mrpackethead opened this issue Aug 9, 2023 · 1 comment

Comments

@mrpackethead
Copy link
Contributor

.....I'd prefer to see this as an enum like class instead of an actual enum so that it's more extensible if options or props need to be added to potential auth types.

Originally posted by @TheRealAmazonKendra in #506 (comment)

Have replaced using the AuthType ENUM in favor of a Authorizer Class, which today, only returns the type of authorizer ( iam or none ), but will provide a non breaking path for any future auth models that may appear.

@mrgrain
Copy link
Contributor

mrgrain commented Oct 13, 2023

This seems to be created as a separate issue by mistake.

@mrgrain mrgrain closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants