From 10f4304b156789da9e8c5ab77f9d521c545a355e Mon Sep 17 00:00:00 2001 From: Kaizen Conroy <36202692+kaizencc@users.noreply.github.com> Date: Thu, 14 Jul 2022 22:42:29 -0400 Subject: [PATCH] fix(cli): pin geonamescache dependency to 1.3 (#21152) Our integ tests are failing because geonamescache recently [released](https://github.com/aws/aws-cdk/pull/21152/files) v1.4 and we are hardcoding v1.3 in our cli tests. This is currently blocking CDK v1.164.0's release, which has a p0 fix, so I'm simply pinning the dependency and we can worry about any potentially better solutions later. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --- .../cli/sam_cdk_integ_app/src/python/Function/requirements.txt | 2 +- .../cli/sam_cdk_integ_app/src/python/Layer/requirements.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/aws-cdk/test/integ/cli/sam_cdk_integ_app/src/python/Function/requirements.txt b/packages/aws-cdk/test/integ/cli/sam_cdk_integ_app/src/python/Function/requirements.txt index 63ce47ab440bc..23a7f08699fe4 100644 --- a/packages/aws-cdk/test/integ/cli/sam_cdk_integ_app/src/python/Function/requirements.txt +++ b/packages/aws-cdk/test/integ/cli/sam_cdk_integ_app/src/python/Function/requirements.txt @@ -1 +1 @@ -geonamescache \ No newline at end of file +geonamescache==1.3.0 \ No newline at end of file diff --git a/packages/aws-cdk/test/integ/cli/sam_cdk_integ_app/src/python/Layer/requirements.txt b/packages/aws-cdk/test/integ/cli/sam_cdk_integ_app/src/python/Layer/requirements.txt index 63ce47ab440bc..5071aed63f51f 100644 --- a/packages/aws-cdk/test/integ/cli/sam_cdk_integ_app/src/python/Layer/requirements.txt +++ b/packages/aws-cdk/test/integ/cli/sam_cdk_integ_app/src/python/Layer/requirements.txt @@ -1 +1 @@ -geonamescache \ No newline at end of file +geonamescache==1.3.0