Skip to content

Commit 1c4ac10

Browse files
authored
docs(eks-v2-alpha): remove spot instance related documentation (#34384)
### Issue # (if applicable) None ### Reason for this change [spot interrupt handler is installed by default in aws-eks](https://github.com/aws/aws-cdk/blob/393919f760a9257886536e37596dbac6119a9acc/packages/aws-cdk-lib/aws-eks/lib/cluster.ts#L1178-L1182), but not in eks-v2-alpha. ### Description of changes Remove spot instance related documentation in eks-v2-alpha. ### Describe any new or updated permissions being added ### Description of how you validated changes This is a documentation-only change. No test modifications are required. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 45f4402 commit 1c4ac10

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

packages/@aws-cdk/aws-eks-v2-alpha/lib/cluster.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -177,12 +177,6 @@ export interface ICluster extends IResource, ec2.IConnectable {
177177
* add the right policies to the instance role, apply the right tags, and add
178178
* the required user data to the instance's launch configuration.
179179
*
180-
* Spot instances will be labeled `lifecycle=Ec2Spot` and tainted with `PreferNoSchedule`.
181-
* If kubectl is enabled, the
182-
* [spot interrupt handler](https://github.com/awslabs/ec2-spot-labs/tree/master/ec2-spot-eks-solution/spot-termination-handler)
183-
* daemon will be installed on all spot instances to handle
184-
* [EC2 Spot Instance Termination Notices](https://aws.amazon.com/blogs/aws/new-ec2-spot-instance-termination-notices/).
185-
*
186180
* Prefer to use `addAutoScalingGroupCapacity` if possible.
187181
*
188182
* @see https://docs.aws.amazon.com/eks/latest/userguide/launch-workers.html
@@ -811,12 +805,6 @@ abstract class ClusterBase extends Resource implements ICluster {
811805
* add the right policies to the instance role, apply the right tags, and add
812806
* the required user data to the instance's launch configuration.
813807
*
814-
* Spot instances will be labeled `lifecycle=Ec2Spot` and tainted with `PreferNoSchedule`.
815-
* If kubectl is enabled, the
816-
* [spot interrupt handler](https://github.com/awslabs/ec2-spot-labs/tree/master/ec2-spot-eks-solution/spot-termination-handler)
817-
* daemon will be installed on all spot instances to handle
818-
* [EC2 Spot Instance Termination Notices](https://aws.amazon.com/blogs/aws/new-ec2-spot-instance-termination-notices/).
819-
*
820808
* Prefer to use `addAutoScalingGroupCapacity` if possible.
821809
*
822810
* @see https://docs.aws.amazon.com/eks/latest/userguide/launch-workers.html
@@ -1428,10 +1416,6 @@ export class Cluster extends ClusterBase {
14281416
* time without notice in case the recommended AMI for your machine image type has been updated by AWS.
14291417
* The default behavior for `updateType` is `None`, which means only new instances will be launched using the new AMI.
14301418
*
1431-
* Spot instances will be labeled `lifecycle=Ec2Spot` and tainted with `PreferNoSchedule`.
1432-
* In addition, the [spot interrupt handler](https://github.com/awslabs/ec2-spot-labs/tree/master/ec2-spot-eks-solution/spot-termination-handler)
1433-
* daemon will be installed on all spot instances to handle
1434-
* [EC2 Spot Instance Termination Notices](https://aws.amazon.com/blogs/aws/new-ec2-spot-instance-termination-notices/).
14351419
*/
14361420
@MethodMetadata()
14371421
public addAutoScalingGroupCapacity(id: string, options: AutoScalingGroupCapacityOptions): autoscaling.AutoScalingGroup {

0 commit comments

Comments
 (0)