Skip to content

Commit 50bd5ce

Browse files
committed
Fix eslint in aws-cdk-lib/cx-api/lib/features.ts
1 parent df4f636 commit 50bd5ce

File tree

3 files changed

+23
-1
lines changed

3 files changed

+23
-1
lines changed

packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ Flags come in three types:
102102
| [@aws-cdk/s3-notifications:addS3TrustKeyPolicyForSnsSubscriptions](#aws-cdks3-notificationsadds3trustkeypolicyforsnssubscriptions) | Add an S3 trust policy to a KMS key resource policy for SNS subscriptions. | 2.195.0 | fix |
103103
| [@aws-cdk/aws-ec2:requirePrivateSubnetsForEgressOnlyInternetGateway](#aws-cdkaws-ec2requireprivatesubnetsforegressonlyinternetgateway) | When enabled, the EgressOnlyGateway resource is only created if private subnets are defined in the dual-stack VPC. | 2.196.0 | fix |
104104
| [@aws-cdk/aws-s3:publicAccessBlockedByDefault](#aws-cdkaws-s3publicaccessblockedbydefault) | When enabled, setting any combination of options for BlockPublicAccess will automatically set true for any options not defined. | 2.196.0 | fix |
105+
| [@aws-cdk/aws-kms:applyImportedAliasPermissionsToPrincipal](#aws-cdkaws-kmsapplyimportedaliaspermissionstoprincipal) | Enable grant methods on Aliases imported by name to use kms:ResourceAliases condition | V2NEXT | fix |
105106

106107
<!-- END table -->
107108

@@ -145,6 +146,7 @@ The following json shows the current recommended set of flags, as `cdk init` wou
145146
"@aws-cdk/aws-ec2:restrictDefaultSecurityGroup": true,
146147
"@aws-cdk/aws-apigateway:requestValidatorUniqueId": true,
147148
"@aws-cdk/aws-kms:aliasNameRef": true,
149+
"@aws-cdk/aws-kms:applyImportedAliasPermissionsToPrincipal": true,
148150
"@aws-cdk/aws-autoscaling:generateLaunchTemplateInsteadOfLaunchConfig": true,
149151
"@aws-cdk/core:includePrefixInUniqueNameGeneration": true,
150152
"@aws-cdk/aws-efs:denyAnonymousAccess": true,
@@ -2142,4 +2144,23 @@ The new behavior from this feature will allow a user, for example, to set 1 of t
21422144
| 2.196.0 | `false` | `true` |
21432145

21442146

2147+
### @aws-cdk/aws-kms:applyImportedAliasPermissionsToPrincipal
2148+
2149+
*Enable grant methods on Aliases imported by name to use kms:ResourceAliases condition*
2150+
2151+
Flag type: Backwards incompatible bugfix
2152+
2153+
This flag enables the grant methods (grant, grantDecrypt, grantEncrypt, etc.) on Aliases imported
2154+
by name to grant permissions based on the 'kms:ResourceAliases' condition rather than no-op grants.
2155+
When disabled, grant calls on imported aliases will be dropped (no-op) to maintain compatibility.
2156+
2157+
2158+
| Since | Default | Recommended |
2159+
| ----- | ----- | ----- |
2160+
| (not in v1) | | |
2161+
| V2NEXT | `false` | `true` |
2162+
2163+
**Compatibility with old behavior:** Remove calls to the grant* methods on the aliases referenced by name
2164+
2165+
21452166
<!-- END details -->

packages/aws-cdk-lib/cx-api/lib/features.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -856,7 +856,7 @@ export const FLAGS: Record<string, FlagInfo> = {
856856
`,
857857
introducedIn: { v2: 'V2NEXT' },
858858
recommendedValue: true,
859-
compatibilityWithOldBehaviorMd: `Remove calls to the grant* methods on the aliases referenced by name`,
859+
compatibilityWithOldBehaviorMd: 'Remove calls to the grant* methods on the aliases referenced by name',
860860
},
861861

862862
//////////////////////////////////////////////////////////////////////

packages/aws-cdk-lib/recommended-feature-flags.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
"@aws-cdk/aws-ec2:restrictDefaultSecurityGroup": true,
3232
"@aws-cdk/aws-apigateway:requestValidatorUniqueId": true,
3333
"@aws-cdk/aws-kms:aliasNameRef": true,
34+
"@aws-cdk/aws-kms:applyImportedAliasPermissionsToPrincipal": true,
3435
"@aws-cdk/aws-autoscaling:generateLaunchTemplateInsteadOfLaunchConfig": true,
3536
"@aws-cdk/core:includePrefixInUniqueNameGeneration": true,
3637
"@aws-cdk/aws-efs:denyAnonymousAccess": true,

0 commit comments

Comments
 (0)