From 671b7606ec7d276724ad8ea80695d78a2abac472 Mon Sep 17 00:00:00 2001 From: "k.goto" <24818752+go-to-k@users.noreply.github.com> Date: Thu, 19 Oct 2023 02:47:08 +0900 Subject: [PATCH] docs(secretsmanager): doc when automaticallyAfter for RotationSchedule is 0 is wrong (#27570) We discussed that the doc when `automaticallyAfter` for `RotationSchedule` is `Duration.days(0)` is wrong. So I modified the doc. See the issue (https://github.com/aws/aws-cdk/issues/27460) and another PR (https://github.com/aws/aws-cdk/pull/27497#issuecomment-1765140245). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --- .../aws-cdk-lib/aws-secretsmanager/lib/rotation-schedule.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/aws-cdk-lib/aws-secretsmanager/lib/rotation-schedule.ts b/packages/aws-cdk-lib/aws-secretsmanager/lib/rotation-schedule.ts index b2460667599f1..7002dc99ee6ad 100644 --- a/packages/aws-cdk-lib/aws-secretsmanager/lib/rotation-schedule.ts +++ b/packages/aws-cdk-lib/aws-secretsmanager/lib/rotation-schedule.ts @@ -37,7 +37,7 @@ export interface RotationScheduleOptions { * Specifies the number of days after the previous rotation before * Secrets Manager triggers the next automatic rotation. * - * A value of zero will disable automatic rotation - `Duration.days(0)`. + * A value of zero (`Duration.days(0)`) will not create RotationRules. * * @default Duration.days(30) */