From aedee00e2ae73c0a5046cdbb53ff3d2f5b9751f9 Mon Sep 17 00:00:00 2001 From: Kendra Neil <53584728+TheRealAmazonKendra@users.noreply.github.com> Date: Tue, 4 Oct 2022 17:35:47 -0400 Subject: [PATCH] chore: do not dismiss changes requested by aws-cdk-automation (#22350) This will keep the pr-linter reviews from being dismissed until the checks pass and will quiet down the noise made by the pr linter. --- .mergify.yml | 1 + tools/@aws-cdk/prlint/lint.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.mergify.yml b/.mergify.yml index f626f6fcf428d..0869261bf3472 100644 --- a/.mergify.yml +++ b/.mergify.yml @@ -95,6 +95,7 @@ pull_request_rules: - base=main - -merged - -closed + - changes-requested-reviews-by!=aws-cdk-automation - name: if fails conventional commits actions: comment: diff --git a/tools/@aws-cdk/prlint/lint.ts b/tools/@aws-cdk/prlint/lint.ts index f2dfe1b2df60a..d01c3f2121126 100644 --- a/tools/@aws-cdk/prlint/lint.ts +++ b/tools/@aws-cdk/prlint/lint.ts @@ -246,7 +246,7 @@ export class PullRequestLinter { * @returns Existing comment, if present */ private async findExistingComment(): Promise { - const comments = await this.client.issues.listComments(); + const comments = await this.client.issues.listComments(this.issueParams); return comments.data.find((comment) => comment.user?.login === 'aws-cdk-automation' && comment.body?.startsWith('The pull request linter fails with the following errors:')) as Comment; }